Issue 1581393008: Rename DART_PRECOMPILED -> DART_PRECOMPILED_RUNTIME

Issue 1581393008: Rename DART_PRECOMPILED -> DART_PRECOMPILED_RUNTIME (Closed)

Created:
4 years, 11 months ago by Florian Schneider

Modified:
4 years, 11 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, ricow1, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Rename DART_PRECOMPILED -> DART_PRECOMPILED_RUNTIME To avoid future confusion with precompiler compiler-related macros/build targets BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/f47839ba09c676a0b2b5a15eba4f542ca8af480c

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -25 lines)			Patch
M	dart.gyp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/bin.gypi	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/dart-runtime.gyp	View	1 2	3 chunks	+4 lines, -3 lines	0 comments	Download
M	runtime/vm/compiler.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	1 2 3	3 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/parser.cc	View	1 2 3	3 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/stub_code.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/vm.gypi	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/standalone/precompilation_dart2js_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/standalone/precompilation_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/precompilation/test_linux.sh	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/precompilation/test_linux_simarm.sh	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/precompilation/test_macos.sh	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/testing/dart/test_suite.dart	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (3 generated)

rmacnak

lgtm w/c Also update dartPrecompiledBinaryFileName in tools/testings/dart/test_suite.dart.

4 years, 11 months ago (2016-01-15 20:44:17 UTC) #4

Florian Schneider

4 years, 11 months ago (2016-01-19 21:59:53 UTC) #6

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as
f47839ba09c676a0b2b5a15eba4f542ca8af480c (presubmit successful).