Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 1581393003: Reland of [wasm] Add tests for JS wrappers to test-run-wasm. (Closed)

Created:
4 years, 11 months ago by titzer
Modified:
4 years, 11 months ago
Reviewers:
bradnelson, ahaas
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of [wasm] Add tests for JS wrappers to test-run-wasm. Fix: pass global object as receiver when calling WASM->JS. R=bradnelson@chromium.org, ahaas@chromium.org BUG= Committed: https://crrev.com/d1bc4f0e27871040d80c4332c29e0eb8eac7dc7f Cr-Commit-Position: refs/heads/master@{#33286}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+555 lines, -382 lines) Patch
M src/compiler/wasm-compiler.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/wasm/wasm-js.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/wasm/wasm-js.cc View 2 chunks +14 lines, -6 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/wasm/test-run-wasm.cc View 2 chunks +2 lines, -375 lines 0 comments Download
A test/cctest/wasm/test-run-wasm-js.cc View 1 chunk +141 lines, -0 lines 0 comments Download
A test/cctest/wasm/wasm-run-utils.h View 1 chunk +391 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
titzer
4 years, 11 months ago (2016-01-14 09:25:29 UTC) #1
ahaas
lgtm
4 years, 11 months ago (2016-01-14 09:44:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1581393003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1581393003/1
4 years, 11 months ago (2016-01-14 09:46:00 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-14 09:48:52 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 09:49:10 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d1bc4f0e27871040d80c4332c29e0eb8eac7dc7f
Cr-Commit-Position: refs/heads/master@{#33286}

Powered by Google App Engine
This is Rietveld 408576698