Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(7)

Issue 1581343002: [turbofan] Add support for inlining bound functions. (Closed)

Created:
2 years ago by Benedikt Meurer
Modified:
2 years ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add support for inlining bound functions. Support inlining across bound functions in the JSCallReducer when we specialize to the native context. This basically removes all overhead from bound functions in TurboFan and gives another speed of 10x on my microbenchmark. BUG=chromium:535408, chromium:571299, v8:4629 R=jarin@chromium.org LOG=n Committed: https://crrev.com/ae679c5496b9afe26544467e3b9d64a7ca4839de Cr-Commit-Position: refs/heads/master@{#33283}

Patch Set 1 #

Patch Set 2 : Fix typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -1 line) Patch
M src/compiler/js-call-reducer.cc View 1 1 chunk +35 lines, -1 line 0 comments Download
Trybot results:

Messages

Total messages: 9 (3 generated)
Benedikt Meurer
2 years ago (2016-01-14 06:24:33 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1581343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1581343002/1
2 years ago (2016-01-14 06:25:38 UTC) #3
Jarin
lgtm. awesome!
2 years ago (2016-01-14 06:30:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1581343002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1581343002/20001
2 years ago (2016-01-14 06:30:27 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
2 years ago (2016-01-14 07:14:03 UTC) #7
commit-bot: I haz the power
2 years ago (2016-01-14 07:15:07 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ae679c5496b9afe26544467e3b9d64a7ca4839de
Cr-Commit-Position: refs/heads/master@{#33283}

Powered by Google App Engine
This is Rietveld 0eb02b776