Make VisibleSelection::setWithoutValidation() to handle TextAffinity::Upstream

Make VisibleSelection::setWithoutValidation() to handle TextAffinity::Upstream

Before this patch, |VisibleSelection::setWithoutValidation()| assumes it is
always called |m_affinity| == |TextAffinity::Downstream|, however as attached
test case, "/set-without-validation-with-upstream-caret.html", this assumption
is false. |setWithoutValidation()| can be called with
|m_affinity| == |TextAffinity::Upstream|.

This patch makes |VisibleSelection::setWithoutValidation()| to handle in case
of |VisibleSelection::m_affinity| == |TextAffinity::Upstream| case by keeping
invariant only caret selection having |TextAffinity::Upstream|.

BUG=575568
TEST=editing/caret/set-without-validation-with-upstream-caret.html

Committed: https://crrev.com/57ff0386acaed36fc1cfcb86432d53b84d747e36
Cr-Commit-Position: refs/heads/master@{#369363}

[yosin_UTC9, 2016-01-14 06:04:38]

Description was changed from

==========
Make VisibleSelection::setWithoutValidation() to handle TextAffinity::Upstream

BUG=575668
==========

to

==========
Make VisibleSelection::setWithoutValidation() to handle TextAffinity::Upstream

BUG=575668
TEST=editing/caret/set-without-validation-with-upstream-caret.html
==========

[yosin_UTC9, 2016-01-14 06:04:48]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-14 06:05:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1581333002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1581333002/1

[yosin_UTC9, 2016-01-14 06:10:45]

Description was changed from

==========
Make VisibleSelection::setWithoutValidation() to handle TextAffinity::Upstream

BUG=575668
TEST=editing/caret/set-without-validation-with-upstream-caret.html
==========

to

==========
Make VisibleSelection::setWithoutValidation() to handle TextAffinity::Upstream

BUG=575568
TEST=editing/caret/set-without-validation-with-upstream-caret.html
==========

[yosin_UTC9, 2016-01-14 06:36:28]

Description was changed from

==========
Make VisibleSelection::setWithoutValidation() to handle TextAffinity::Upstream

BUG=575568
TEST=editing/caret/set-without-validation-with-upstream-caret.html
==========

to

==========
Make VisibleSelection::setWithoutValidation() to handle TextAffinity::Upstream

Before this patch, |VisibleSelection::setWithoutValidation()| assumes it is
always called |m_affinity| == |TextAffinity::Downstream|, however as attached
test case, "/set-without-validation-with-upstream-caret.html", this assumption
is false. |setWithoutValidation()| can be called with
|m_affinity| == |TextAffinity::Upstream|.

This patch makes |VisibleSelection::setWithoutValidation()| to handle in case
of |VisibleSelection::m_affinity| == |TextAffinity::Upstream| case by keeping
invariant only caret selection having |TextAffinity::Upstream|.

BUG=575568
TEST=editing/caret/set-without-validation-with-upstream-caret.html
==========

[yosin_UTC9, 2016-01-14 06:36:28]

yosin@chromium.org changed reviewers:
+ hajimehoshi@chromium.org, xiaochengh@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2016-01-14 06:37:25]

Finally, we get a test case for setWithoutValidation() with upstream caret, so
we can get rid of
false assert. (^_^)b

[hajimehoshi, 2016-01-14 06:57:59]

lgtm

[Xiaocheng, 2016-01-14 07:17:35]

On 2016/01/14 at 06:57:59, hajimehoshi wrote:
> lgtm

Looks pretty neat to me.

(I am told that I shouldn't add that 4-letter message in my review before being
a committer)

[commit-bot: I haz the power, 2016-01-14 07:21:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-14 07:21:19]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2016-01-14 07:36:10]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2016-01-14 07:36:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1581333002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1581333002/1

[commit-bot: I haz the power, 2016-01-14 07:40:10]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-14 07:44:27]

Description was changed from

==========
Make VisibleSelection::setWithoutValidation() to handle TextAffinity::Upstream

Before this patch, |VisibleSelection::setWithoutValidation()| assumes it is
always called |m_affinity| == |TextAffinity::Downstream|, however as attached
test case, "/set-without-validation-with-upstream-caret.html", this assumption
is false. |setWithoutValidation()| can be called with
|m_affinity| == |TextAffinity::Upstream|.

This patch makes |VisibleSelection::setWithoutValidation()| to handle in case
of |VisibleSelection::m_affinity| == |TextAffinity::Upstream| case by keeping
invariant only caret selection having |TextAffinity::Upstream|.

BUG=575568
TEST=editing/caret/set-without-validation-with-upstream-caret.html
==========

to

==========
Make VisibleSelection::setWithoutValidation() to handle TextAffinity::Upstream

Before this patch, |VisibleSelection::setWithoutValidation()| assumes it is
always called |m_affinity| == |TextAffinity::Downstream|, however as attached
test case, "/set-without-validation-with-upstream-caret.html", this assumption
is false. |setWithoutValidation()| can be called with
|m_affinity| == |TextAffinity::Upstream|.

This patch makes |VisibleSelection::setWithoutValidation()| to handle in case
of |VisibleSelection::m_affinity| == |TextAffinity::Upstream| case by keeping
invariant only caret selection having |TextAffinity::Upstream|.

BUG=575568
TEST=editing/caret/set-without-validation-with-upstream-caret.html

Committed: https://crrev.com/57ff0386acaed36fc1cfcb86432d53b84d747e36
Cr-Commit-Position: refs/heads/master@{#369363}
==========

[commit-bot: I haz the power, 2016-01-14 07:44:28]

Patchset 1 (id:??) landed as
https://crrev.com/57ff0386acaed36fc1cfcb86432d53b84d747e36
Cr-Commit-Position: refs/heads/master@{#369363}