Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 158133004: gpu: Use a single container for GLInProcessContext share group (Closed)

Created:
6 years, 10 months ago by no sievers
Modified:
6 years, 10 months ago
Reviewers:
piman
CC:
chromium-reviews, piman+watch_chromium.org, boliu
Visibility:
Public.

Description

gpu: Use a single container for GLInProcessContext share group Instead of having two global containers for GLInProcessContext and InProcessCommandBuffer, use a single one for the former and pass in the service-side share group while we are holding the lock anyways. This makes it simpler to support multiple service threads. BUG=332146 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250765

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -74 lines) Patch
M gpu/command_buffer/client/gl_in_process_context.cc View 4 chunks +5 lines, -8 lines 0 comments Download
M gpu/command_buffer/service/in_process_command_buffer.h View 6 chunks +8 lines, -7 lines 0 comments Download
M gpu/command_buffer/service/in_process_command_buffer.cc View 13 chunks +18 lines, -59 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
no sievers
https://codereview.chromium.org/158133004/diff/1/gpu/command_buffer/service/in_process_command_buffer.cc File gpu/command_buffer/service/in_process_command_buffer.cc (left): https://codereview.chromium.org/158133004/diff/1/gpu/command_buffer/service/in_process_command_buffer.cc#oldcode546 gpu/command_buffer/service/in_process_command_buffer.cc:546: (*it)->context_lost_ = true; glLoseContextCHROMIUM() already propagates the lost context ...
6 years, 10 months ago (2014-02-12 01:24:32 UTC) #1
piman
lgtm
6 years, 10 months ago (2014-02-12 01:41:12 UTC) #2
no sievers
The CQ bit was checked by sievers@chromium.org
6 years, 10 months ago (2014-02-12 17:15:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sievers@chromium.org/158133004/1
6 years, 10 months ago (2014-02-12 17:15:56 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-12 18:51:47 UTC) #5
Message was sent while issue was closed.
Change committed as 250765

Powered by Google App Engine
This is Rietveld 408576698