Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2173)

Unified Diff: Source/modules/quota/DOMWindowQuota.h

Issue 158133003: Move quota module to oilpan (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Remove conditional support for GCed-supplements Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/modules/quota/DOMWindowQuota.cpp » ('j') | Source/modules/quota/DOMWindowQuota.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/quota/DOMWindowQuota.h
diff --git a/Source/modules/quota/DOMWindowQuota.h b/Source/modules/quota/DOMWindowQuota.h
index dab72266c7042e8c04abd0133912ace93e3e3291..5e4cfa4c913356aaafced581ed5946f821d41996 100644
--- a/Source/modules/quota/DOMWindowQuota.h
+++ b/Source/modules/quota/DOMWindowQuota.h
@@ -32,6 +32,7 @@
#define DOMWindowQuota_h
#include "core/frame/DOMWindowProperty.h"
+#include "heap/Handle.h"
#include "platform/Supplementable.h"
namespace WebCore {
@@ -41,7 +42,7 @@ class DOMWindow;
class DOMWindowQuota FINAL : public Supplement<DOMWindow>, public DOMWindowProperty {
public:
- virtual ~DOMWindowQuota();
+ virtual ~DOMWindowQuota() { }
tkent 2014/02/10 08:27:40 Why do you change this?
sof 2014/02/10 08:32:13 Why wouldn't you want to see in the header file th
tkent 2014/02/10 08:41:57 This CL should focus on Oilapan transition. Chang
sof 2014/02/10 08:45:09 Hmm.. ok.
sof 2014/02/10 09:07:19 Reverted.
static DOMWindowQuota* from(DOMWindow*);
static DeprecatedStorageInfo* webkitStorageInfo(DOMWindow*);
DeprecatedStorageInfo* webkitStorageInfo() const;
@@ -50,7 +51,7 @@ private:
explicit DOMWindowQuota(DOMWindow*);
static const char* supplementName();
- mutable RefPtr<DeprecatedStorageInfo> m_storageInfo;
+ mutable RefPtrWillBePersistent<DeprecatedStorageInfo> m_storageInfo;
};
} // namespace WebCore
« no previous file with comments | « no previous file | Source/modules/quota/DOMWindowQuota.cpp » ('j') | Source/modules/quota/DOMWindowQuota.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698