Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 1581313002: X87: [builtins] Migrate Number constructor similar to String constructor. (Closed)

Created:
4 years, 11 months ago by zhengxing.li
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [builtins] Migrate Number constructor similar to String constructor. port 322ffda30dfefd7101a2bd93e33563cf19fbb022 (r33265) original commit message: Also migrate the Number constructor to a native builtin, using the same mechanism already used by the String constructor. Otherwise just parsing and compiling the Number constructor to optimized code already eats 2ms on desktop for no good reason, and the resulting optimized code is not even close to awesome. Drive-by-fix: Use correct context for the [[Construct]] case of the String constructor as well, and share some code with it. BUG= Committed: https://crrev.com/fe33d20fd1fb31e1fe22b98be226fe87b2f6cf72 Cr-Commit-Position: refs/heads/master@{#33280}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -25 lines) Patch
M src/x87/builtins-x87.cc View 4 chunks +117 lines, -24 lines 0 comments Download
M src/x87/macro-assembler-x87.h View 2 chunks +8 lines, -1 line 0 comments Download
M src/x87/macro-assembler-x87.cc View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, Thanks!
4 years, 11 months ago (2016-01-14 02:35:55 UTC) #2
Weiliang
lgtm
4 years, 11 months ago (2016-01-14 02:38:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1581313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1581313002/1
4 years, 11 months ago (2016-01-14 02:39:01 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-14 03:33:35 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 03:34:08 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fe33d20fd1fb31e1fe22b98be226fe87b2f6cf72
Cr-Commit-Position: refs/heads/master@{#33280}

Powered by Google App Engine
This is Rietveld 408576698