Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 15813005: MIPS: Fix DIRECT_API_CALL_NEW and DIRECT_GETTER_CALL_NEW call. (Closed)

Created:
7 years, 7 months ago by palfia
Modified:
7 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Fix DIRECT_API_CALL_NEW and DIRECT_GETTER_CALL_NEW call. This commit fixes the register usage of DIRECT_API_CALL_NEW and DIRECT_GETTER_CALL_NEW: * These functions expect arguments in a0-a1 and not in a1-a2 as the and DIRECT_API_CALL and DIRECT_GETTER_CALL do. * Fixes the simulator to expect *_NEW arguments in a0-a1. * Adds more comment to simulator to better explain the register usage. TEST=cctest/test-api/LoadICFastApi_DirectCall_GCMoveStub,cctest/test-api/SimpleCallback BUG= Committed: https://code.google.com/p/v8/source/detail?r=14813

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -32 lines) Patch
M src/mips/macro-assembler-mips.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/mips/simulator-mips.cc View 2 chunks +29 lines, -12 lines 0 comments Download
M src/mips/stub-cache-mips.cc View 3 chunks +26 lines, -19 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
palfia
7 years, 7 months ago (2013-05-25 15:23:19 UTC) #1
Paul Lind
lgtm, thanks!
7 years, 7 months ago (2013-05-25 15:51:31 UTC) #2
palfia
7 years, 7 months ago (2013-05-25 17:10:50 UTC) #3
Message was sent while issue was closed.
Committed manually as r14813 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698