Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Unified Diff: pkg/analyzer/lib/src/generated/incremental_logger.dart

Issue 1581293002: Issue 25064. Incrementally resolve comments only if both are documentation. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/generated/incremental_logger.dart
diff --git a/pkg/analyzer/lib/src/generated/incremental_logger.dart b/pkg/analyzer/lib/src/generated/incremental_logger.dart
index d942aba8a3c307ab8115c1f232318336cebaf669..1de253445cd45f4a274b9ca6c34e47cc4575f56e 100644
--- a/pkg/analyzer/lib/src/generated/incremental_logger.dart
+++ b/pkg/analyzer/lib/src/generated/incremental_logger.dart
@@ -40,6 +40,11 @@ abstract class Logger {
void log(Object obj);
/**
+ * Logs the given [exception] and [stackTrace].
+ */
+ void logException(Object exception, [Object stackTrace]);
+
+ /**
* Starts a new timer.
*/
LoggingTimer startTimer();
@@ -102,6 +107,16 @@ class StringSinkLogger implements Logger {
}
@override
+ void logException(Object exception, [Object stackTrace]) {
+ if (exception != null) {
+ log(exception);
+ }
+ if (stackTrace != null) {
+ log(stackTrace);
+ }
+ }
+
+ @override
LoggingTimer startTimer() {
return new LoggingTimer(this);
}
@@ -147,6 +162,9 @@ class _NullLogger implements Logger {
void log(Object obj) {}
@override
+ void logException(Object exception, [Object stackTrace]) {}
+
+ @override
LoggingTimer startTimer() {
return new LoggingTimer(this);
}

Powered by Google App Engine
This is Rietveld 408576698