Harden CommandBufferProxyImpl

Harden CommandBufferProxyImpl

This avoids a class of errors where a message/reply from the GPU process
is received that indicates invalid state.

BUG=563964
Committed: https://crrev.com/79010e270b284c31cdf13eaef4249682c75c794c
Cr-Commit-Position: refs/heads/master@{#369509}

[piman, 2016-01-14 01:10:08]

piman@chromium.org changed reviewers:
+ isherman@chromium.org, vmiura@chromium.org

[piman, 2016-01-14 01:10:08]

vmiura: please review
isherman: histograms.xml

This is not exhaustive, but should take care of the specific issue mentioned in
the bug.

[Ilya Sherman, 2016-01-14 01:11:57]

histograms.xml lgtm

[vmiura, 2016-01-14 05:02:11]

https://codereview.chromium.org/1581273002/diff/1/content/common/gpu/client/c...
File content/common/gpu/client/command_buffer_proxy_impl.cc (right):

https://codereview.chromium.org/1581273002/diff/1/content/common/gpu/client/c...
content/common/gpu/client/command_buffer_proxy_impl.cc:125:
context_lost_callback_.Run();
Is it OK that we will run the context lost callback in a
WaitForToken*/WaitForGet* stack (potentially from a raster worker thread)?

[piman, 2016-01-14 15:18:44]

The CQ bit was checked by piman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-14 15:19:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1581273002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1581273002/1

[commit-bot: I haz the power, 2016-01-14 16:03:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-14 16:03:05]

Dry run: This issue passed the CQ dry run.

[piman, 2016-01-14 18:26:51]

The CQ bit was checked by piman@chromium.org to run a CQ dry run

[piman, 2016-01-14 18:27:58]

https://codereview.chromium.org/1581273002/diff/1/content/common/gpu/client/c...
File content/common/gpu/client/command_buffer_proxy_impl.cc (right):

https://codereview.chromium.org/1581273002/diff/1/content/common/gpu/client/c...
content/common/gpu/client/command_buffer_proxy_impl.cc:125:
context_lost_callback_.Run();
On 2016/01/14 05:02:11, vmiura wrote:
> Is it OK that we will run the context lost callback in a
> WaitForToken*/WaitForGet* stack (potentially from a raster worker thread)?

Good catch, no it's not OK, actually whether or not it's in the same thread.
Fixed in latest patch (run directly when receiving a message, post a task when
we would re-enter).

[commit-bot: I haz the power, 2016-01-14 18:28:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1581273002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1581273002/20001

[vmiura, 2016-01-14 18:59:27]

lgtm

[piman, 2016-01-14 19:11:39]

The CQ bit was unchecked by piman@chromium.org

[piman, 2016-01-14 19:11:40]

The CQ bit was checked by piman@chromium.org

[piman, 2016-01-14 19:11:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/1581273002/#ps20001
(title: "Post a task for lost context callback when in a reply")

[piman, 2016-01-14 19:11:46]

The CQ bit was checked by piman@chromium.org

[commit-bot: I haz the power, 2016-01-14 19:12:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1581273002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1581273002/20001

[commit-bot: I haz the power, 2016-01-14 19:41:03]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-14 19:43:17]

Description was changed from

==========
Harden CommandBufferProxyImpl

This avoids a class of errors where a message/reply from the GPU process
is received that indicates invalid state.

BUG=563964
==========

to

==========
Harden CommandBufferProxyImpl

This avoids a class of errors where a message/reply from the GPU process
is received that indicates invalid state.

BUG=563964

Committed: https://crrev.com/79010e270b284c31cdf13eaef4249682c75c794c
Cr-Commit-Position: refs/heads/master@{#369509}
==========

[commit-bot: I haz the power, 2016-01-14 19:43:18]

Patchset 2 (id:??) landed as
https://crrev.com/79010e270b284c31cdf13eaef4249682c75c794c
Cr-Commit-Position: refs/heads/master@{#369509}