Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1581253002: aw: Configurable system_webview_apk package name (Closed)

Created:
4 years, 11 months ago by boliu
Modified:
4 years, 11 months ago
Reviewers:
michaelbai
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

aw: Configurable system_webview_apk package name under GN. GYP has the same define as well. Makes packaging webview under a different package (for external developers) easier. Plus I personally use it for development. Committed: https://crrev.com/10ada8c226b7b569c3b20b8d594fb0fbcae2b995 Cr-Commit-Position: refs/heads/master@{#369331}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M android_webview/BUILD.gn View 3 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
boliu
ptal
4 years, 11 months ago (2016-01-14 00:22:01 UTC) #3
michaelbai
lgtm
4 years, 11 months ago (2016-01-14 01:04:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1581253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1581253002/1
4 years, 11 months ago (2016-01-14 01:10:50 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_TIMED_OUT, no build URL) android_chromium_gn_compile_dbg on ...
4 years, 11 months ago (2016-01-14 03:18:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1581253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1581253002/1
4 years, 11 months ago (2016-01-14 05:00:17 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-14 05:08:33 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 05:09:40 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/10ada8c226b7b569c3b20b8d594fb0fbcae2b995
Cr-Commit-Position: refs/heads/master@{#369331}

Powered by Google App Engine
This is Rietveld 408576698