Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 1581223003: Ensure that custom property declarations are treated as inherited (Closed)

Created:
4 years, 11 months ago by shans
Modified:
4 years, 11 months ago
Reviewers:
Timothy Loh
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure that custom property declarations are treated as inherited properties. Without this patch, when an ancestor modifies custom property values then children that make use of just the non-inherited part of the matched properties cache won't apply any custom property value overrides, as they aren't flagged as inherited. BUG=570164 Committed: https://crrev.com/70dd938c9205b4799e6ef704f98513f37b2d1572 Cr-Commit-Position: refs/heads/master@{#369370}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/fast/css/variables/recompute-variables-when-parent-style-updates.html View 1 chunk +40 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/templates/CSSPropertyMetadata.cpp.tmpl View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
shans
4 years, 11 months ago (2016-01-14 05:17:03 UTC) #2
Timothy Loh
lgtm
4 years, 11 months ago (2016-01-14 05:22:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1581223003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1581223003/1
4 years, 11 months ago (2016-01-14 06:38:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-14 08:41:27 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 08:43:57 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/70dd938c9205b4799e6ef704f98513f37b2d1572
Cr-Commit-Position: refs/heads/master@{#369370}

Powered by Google App Engine
This is Rietveld 408576698