Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 1581203003: some fuzz hacking (Closed)

Created:
4 years, 11 months ago by mtklein_C
Modified:
4 years, 11 months ago
Reviewers:
kjlubick
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

some fuzz hacking Try to start faster: - remove flags dependency - print nothing - strip unused symbols from the binary on Mac (smaller binary) - only create one fuzz object - only run one DEF_FUZZ I am not sure if any of these things mattered, but I thought you may like to look. Good stuff: - make nextU() / nextF() work - drop nextURange() / nextFRange() for now - add nextB() for a single byte As you may have guessed, I have figured out how to use afl-fuzz on my laptop. Syntax to run becomes: $ afl-fuzz ... out/Release/fuzz <DEF_FUZZ name> @@ BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1581203003 Committed: https://skia.googlesource.com/skia/+/24a22c7de8890642e43d6ae1115ecd59e2f8f0db

Patch Set 1 #

Patch Set 2 : unused #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -30 lines) Patch
M fuzz/Fuzz.h View 1 1 chunk +2 lines, -4 lines 0 comments Download
M fuzz/FuzzPaeth.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M fuzz/fuzz.cpp View 1 chunk +25 lines, -19 lines 0 comments Download
M gyp/fuzz.gyp View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
mtklein_C
4 years, 11 months ago (2016-01-14 04:49:46 UTC) #13
kjlubick
lgtm
4 years, 11 months ago (2016-01-14 12:36:24 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1581203003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1581203003/20001
4 years, 11 months ago (2016-01-14 12:48:55 UTC) #16
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 12:59:46 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/24a22c7de8890642e43d6ae1115ecd59e2f8f0db

Powered by Google App Engine
This is Rietveld 408576698