Make file_util::CreateDirectory return an error, not just a bool

third_party/leveldatabase/env_chromium.cc

 // Copyright (c) 2011 The LevelDB Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file. See the AUTHORS file for names of contributors.
 
 #include <errno.h>
 #include <stdio.h>
 
 #include <deque>
 
 #include "base/at_exit.h"
@@ skipping 579 matching lines @@
   // TODO(jorlow): Should we assert this is a file?
   if (!::file_util::Delete(CreateFilePath(fname), false)) {
     result = MakeIOError(fname, "Could not delete file.", kDeleteFile);
     RecordErrorAt(kDeleteFile);
   }
   return result;
 }
 
 Status ChromiumEnv::CreateDir(const std::string& name) {
   Status result;
-  if (!::file_util::CreateDirectory(CreateFilePath(name))) {
-    result = MakeIOError(name, "Could not create directory.", kCreateDir);
-    RecordErrorAt(kCreateDir);
-  }
+  base::PlatformFileError error = base::PLATFORM_FILE_OK;
+  Retrier retrier(kCreateDir, this);
+  do {
+    if (::file_util::CreateDirectoryAndGetError(CreateFilePath(name), &error)) {
+      return result;
+    }

[jar (doing other things), 2013/06/07 23:32:49]

nit: No need for curlies around this one line result on line 604.  The file is
mostly consistent in not using curlies for this pattern.

[dgrogan, 2013/06/07 23:35:50]

Done.

+  } while (retrier.ShouldKeepTrying(error));
+  result = MakeIOError(name, "Could not create directory.", kCreateDir);
+  RecordErrorAt(kCreateDir);
   return result;
 }
 
 Status ChromiumEnv::DeleteDir(const std::string& name) {
   Status result;
   // TODO(jorlow): Should we assert this is a directory?
   if (!::file_util::Delete(CreateFilePath(name), false)) {
     result = MakeIOError(name, "Could not delete directory.", kDeleteDir);
     RecordErrorAt(kDeleteDir);
   }
@@ skipping 300 matching lines @@
 Env* IDBEnv() {
   return leveldb_env::idb_env.Pointer();
 }
 
 Env* Env::Default() {
   return leveldb_env::default_env.Pointer();
 }
 
 }  // namespace leveldb