Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1581183004: [turbofan] Fix bug in object state generation of escape analysis. (Closed)

Created:
4 years, 11 months ago by sigurds
Modified:
4 years, 11 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix bug in object state generation of escape analysis. Apparently, some StateValues have other StateValues as input. This CL makes escape analysis transformation phase aware of it. R=mstarzinger@chromium.org BUG=v8:4586 LOG=n Committed: https://crrev.com/3743bf4837ef2268e797134c067ae2ffc7031d80 Cr-Commit-Position: refs/heads/master@{#33285}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M src/compiler/escape-analysis-reducer.cc View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
sigurds
PTAL
4 years, 11 months ago (2016-01-14 09:01:17 UTC) #1
Michael Starzinger
LGTM.
4 years, 11 months ago (2016-01-14 09:03:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1581183004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1581183004/1
4 years, 11 months ago (2016-01-14 09:04:27 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-14 09:30:00 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 09:30:15 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3743bf4837ef2268e797134c067ae2ffc7031d80
Cr-Commit-Position: refs/heads/master@{#33285}

Powered by Google App Engine
This is Rietveld 408576698