Issue 1581173004: Added namespace browsing_data_counter_utils

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Created:
4 years, 11 months ago by msramek

Modified:
4 years, 11 months ago

Reviewers:

CC:
chromium-reviews, dbeam+watch-options_chromium.org, markusheintz_, michaelpg+watch-options_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@add-counters

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Added namespace browsing_data_counter_utils In the code review https://codereview.chromium.org/1527653004/diff/20001/chrome/browser/browsing_data/browsing_data_counter_utils.h#newcode10 it was decided to omit a namespace in browsing_data_counter_utils.[cc|h], as other files in the browsing_data/ directory were not enclosed in a namespace either. In the code review https://codereview.chromium.org/1530123002/diff/80001/chrome/browser/browsing_data/browsing_data_counter_utils.h it was suggested that a namespace should be used due to the nature of the file as a set of ad-hoc utility functions not encapsulated in a class. This CL therefore introduces a narrow namespace only enclosing these utility functions. BUG=569870

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -16 lines)			Patch
M	chrome/browser/android/browsing_data/browsing_data_counter_bridge.cc	View	3 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/android/preferences/pref_service_bridge.cc	View	2 chunks	+6 lines, -5 lines	0 comments	Download
M	chrome/browser/browsing_data/browsing_data_counter_utils.h	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/browsing_data/browsing_data_counter_utils.cc	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/browsing_data/browsing_data_counter_utils_unittest.cc	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/options/clear_browser_data_handler.cc	View	6 chunks	+11 lines, -9 lines	0 comments	Download

Depends on Patchset:

Total messages: 1 (1 generated)

Patchset #1 (id:1) has been deleted