Allow to set display "inline" on legend element

Allow to set display "inline" on legend element

StyleAdjuster sets legend element's diplasy as "block" by force.
It disallow to set display "inline" on legend element.

BUG=481983
Committed: https://crrev.com/2383abb8b227d12ae53f2b163b57e02ff63dbf0b
Cr-Commit-Position: refs/heads/master@{#370201}

[Deokjin Kim, 2016-01-14 02:33:05]

Description was changed from

==========
Allow to set display "inline" on legend element

StyleAdjuster sets legend element's diplasy as "block" by force.
It disallow to set display "inline" on legend element.

BUG=481983
==========

to

==========
Allow to set display "inline" on legend element

StyleAdjuster sets legend element's diplasy as "block" by force.
It disallow to set display "inline" on legend element.

BUG=481983
==========

[Deokjin Kim, 2016-01-14 02:33:05]

deokjin81.kim@samsung.com changed reviewers:
+ dstockwell@chromium.org, eae@chromium.org, mstensho@opera.com

[Deokjin Kim, 2016-01-14 02:33:31]

PTAL.

[mstensho (USE GERRIT), 2016-01-18 19:33:18]

More work and testing is needed.

This now crashes:

<fieldset>
    <legend style="display:inline;"></legend>
</fieldset>

https://codereview.chromium.org/1581173003/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/fast/forms/fieldset/inline-legend.html
(right):

https://codereview.chromium.org/1581173003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/forms/fieldset/inline-legend.html:12: The
next two sentences should be on same lines.
... on the same *line*

[Deokjin Kim, 2016-01-19 15:37:37]

On 2016/01/18 19:33:18, mstensho wrote:
> More work and testing is needed.
> 
> This now crashes:
> 
> <fieldset>
>     <legend style="display:inline;"></legend>
> </fieldset>
To fix crash on debug mode, I inserted "if statement" for type check in
LayoutFieldset::findInFlowLegend().
 
>
https://codereview.chromium.org/1581173003/diff/1/third_party/WebKit/LayoutTe...
> third_party/WebKit/LayoutTests/fast/forms/fieldset/inline-legend.html:12: The
> next two sentences should be on same lines.
> ... on the same *line*
I modified typo.

[mstensho (USE GERRIT), 2016-01-19 17:28:32]

lgtm.

Note that this actually exchanges one compat issue (vs. Gecko) for another. With
this CL, display is always respected, obviously also when the LEGEND is child of
a FIELDSET. This means that we will now longer display the legend as a true
legend for all display types, such as:

<fieldset>
    <legend style="display:inline;">legendary!</legend>
</fieldset>

Or:

<fieldset>
    <legend style="display:table-cell;">legendary!</legend>
</fieldset>

But I think this (if anyone cares at all; IMHO no one should) is way less
serious than being magical about its display type on a general basis, so this CL
is an improvement.

[Deokjin Kim, 2016-01-19 20:32:54]

The CQ bit was checked by deokjin81.kim@samsung.com

[commit-bot: I haz the power, 2016-01-19 20:34:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1581173003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1581173003/20001

[commit-bot: I haz the power, 2016-01-19 22:11:50]

Description was changed from

==========
Allow to set display "inline" on legend element

StyleAdjuster sets legend element's diplasy as "block" by force.
It disallow to set display "inline" on legend element.

BUG=481983
==========

to

==========
Allow to set display "inline" on legend element

StyleAdjuster sets legend element's diplasy as "block" by force.
It disallow to set display "inline" on legend element.

BUG=481983
==========

[commit-bot: I haz the power, 2016-01-19 22:11:51]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-19 22:13:10]

Description was changed from

==========
Allow to set display "inline" on legend element

StyleAdjuster sets legend element's diplasy as "block" by force.
It disallow to set display "inline" on legend element.

BUG=481983
==========

to

==========
Allow to set display "inline" on legend element

StyleAdjuster sets legend element's diplasy as "block" by force.
It disallow to set display "inline" on legend element.

BUG=481983

Committed: https://crrev.com/2383abb8b227d12ae53f2b163b57e02ff63dbf0b
Cr-Commit-Position: refs/heads/master@{#370201}
==========

[commit-bot: I haz the power, 2016-01-19 22:13:11]

Patchset 2 (id:??) landed as
https://crrev.com/2383abb8b227d12ae53f2b163b57e02ff63dbf0b
Cr-Commit-Position: refs/heads/master@{#370201}