Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1191)

Unified Diff: third_party/gflags/BUILD.gn

Issue 1581123002: pull gflags.gyp changes from webrtc (Closed) Base URL: https://chromium.googlesource.com/libyuv/libyuv@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/gflags/gflags.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/gflags/BUILD.gn
diff --git a/third_party/gflags/BUILD.gn b/third_party/gflags/BUILD.gn
index 2b8d9c8d2a6c9ba368241a07349076b8a78fbaa5..913c55875418ee3bf0af39573826d84c05559e46 100644
--- a/third_party/gflags/BUILD.gn
+++ b/third_party/gflags/BUILD.gn
@@ -16,7 +16,7 @@ if (is_win) {
}
config("gflags_config") {
- include_dirs = [
+ include_dirs = [
"$gflags_gen_arch_root/include", # For configured files.
"src", # For everything else.
]
@@ -28,6 +28,13 @@ config("gflags_config") {
"GFLAGS_DLL_DECLARE_FLAG=",
"GFLAGS_DLL_DEFINE_FLAG=",
]
+
+ # GN orders flags on a target before flags from configs. The default config
+ # adds -Wall, and this flag have to be after -Wall -- so they need to
+ # come from a config and can't be on the target directly.
+ if (is_clang) {
+ cflags = [ "-Wno-unused-local-typedef" ]
+ }
}
source_set("gflags") {
@@ -45,9 +52,7 @@ source_set("gflags") {
]
}
- include_dirs = [
- "$gflags_gen_arch_root/include/private", # For config.h
- ]
+ include_dirs = [ "$gflags_gen_arch_root/include/private" ] # For config.h
public_configs = [ ":gflags_config" ]
@@ -60,3 +65,4 @@ source_set("gflags") {
configs -= [ "//build/config/clang:extra_warnings" ]
}
}
+
« no previous file with comments | « no previous file | third_party/gflags/gflags.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698