Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(842)

Issue 1581123002: pull gflags.gyp changes from webrtc (Closed)

Created:
4 years, 11 months ago by fbarchard1
Modified:
4 years, 11 months ago
Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

pull gflags.gyp changes from webrtc gflags has a build warning in the chromium version. ../../third_party/gflags/src/gflags.cc:281:53: error: unused typedef 'true_false_equal' [-Werror,-Wunused-local-typedef] COMPILE_ASSERT(sizeof(kTrue) == sizeof(kFalse), true_false_equal); ^ 1 error generated. [8/231] CXX obj/chromium/src/testing/gtest/src/gtest.gtest.o Its been reported and fixed upstream https://github.com/gflags/gflags/issues/125 But not pulled into chromium. Last update to flags was in 2013. This change disables the warning. R=harryjin@google.com, kjellander@chromium.org, jkellander@chromium.org BUG=libyuv:536, webrtc:5397, webrtc:5398, webrtc:5399 Committed: https://chromium.googlesource.com/libyuv/libyuv/+/f7c6b1a1967c89513d8d6156dc1cf42ca5a16d2c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M third_party/gflags/BUILD.gn View 4 chunks +10 lines, -4 lines 0 comments Download
M third_party/gflags/gflags.gyp View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
fbarchard1
4 years, 11 months ago (2016-01-13 20:25:45 UTC) #1
harryjin
lgtm
4 years, 11 months ago (2016-01-13 21:07:30 UTC) #2
kjellander_chromium
lgtm (my name was misspelled)
4 years, 11 months ago (2016-01-14 18:57:03 UTC) #5
kjellander_chromium
lgtm (my name was misspelled)
4 years, 11 months ago (2016-01-14 18:57:04 UTC) #6
fbarchard1
4 years, 11 months ago (2016-01-14 19:09:33 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f7c6b1a1967c89513d8d6156dc1cf42ca5a16d2c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698