Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 1581103005: Skip failing wasm tests on platforms with function descriptors. (Closed)

Created:
4 years, 11 months ago by MTBrandyberry
Modified:
4 years, 11 months ago
Reviewers:
titzer, bradnelson, ahaas
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Skip failing wasm tests on platforms with function descriptors. Temporarily disable until solution is implemented. R=titzer@chromium.org, bradnelson@chromium.org, ahaas@chromium.org BUG= Committed: https://crrev.com/04f17595227e0e846a27c44d319655932a3896ac Cr-Commit-Position: refs/heads/master@{#33308}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M test/cctest/cctest.status View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
MTBrandyberry
4 years, 11 months ago (2016-01-14 16:57:21 UTC) #1
ahaas
lgtm
4 years, 11 months ago (2016-01-14 16:58:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1581103005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1581103005/1
4 years, 11 months ago (2016-01-14 17:03:38 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/9777)
4 years, 11 months ago (2016-01-14 17:08:36 UTC) #6
MTBrandyberry
On 2016/01/14 17:08:36, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 11 months ago (2016-01-14 17:38:29 UTC) #7
titzer
On 2016/01/14 17:38:29, mtbrandyberry wrote: > On 2016/01/14 17:08:36, commit-bot: I haz the power wrote: ...
4 years, 11 months ago (2016-01-14 17:52:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1581103005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1581103005/1
4 years, 11 months ago (2016-01-14 17:56:18 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-14 17:57:25 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 17:57:47 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/04f17595227e0e846a27c44d319655932a3896ac
Cr-Commit-Position: refs/heads/master@{#33308}

Powered by Google App Engine
This is Rietveld 408576698