third_party/WebKit/Source/platform/exported/WebMediaConstraints.cpp - Issue 1581103002: Use new-style constraints for device selection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/exported/WebMediaConstraints.cpp

Issue 1581103002: Use new-style constraints for device selection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@constraints-errors

Patch Set: Review comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/media/user_media_client_impl.cc ('K') | « third_party/WebKit/Source/modules/mediastream/MediaConstraintsImpl.cpp ('k') | third_party/WebKit/public/platform/WebMediaConstraints.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/exported/WebMediaConstraints.cpp

diff --git a/third_party/WebKit/Source/platform/exported/WebMediaConstraints.cpp b/third_party/WebKit/Source/platform/exported/WebMediaConstraints.cpp

index 414ff8a73818769f97e8db3247e2a251ebad7608..546cd91f71e4f851f402c76b2be515cf10b89699 100644

--- a/third_party/WebKit/Source/platform/exported/WebMediaConstraints.cpp

+++ b/third_party/WebKit/Source/platform/exported/WebMediaConstraints.cpp

@@ -203,6 +203,16 @@ bool StringConstraint::isEmpty() const

return m_exact.isEmpty() && m_ideal.isEmpty();

}

+const WebVector<WebString>& StringConstraint::exact() const

+ return m_exact;

+const WebVector<WebString>& StringConstraint::ideal() const

+ return m_ideal;

bool BooleanConstraint::matches(bool value) const

{

if (m_hasExact && static_cast<bool>(m_exact) != value) {