src/crankshaft/lithium-codegen.cc - Issue 1581083009: Move SourcePosition into separate header file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/crankshaft/lithium-codegen.cc

Issue 1581083009: Move SourcePosition into separate header file. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: src/crankshaft/lithium-codegen.cc

diff --git a/src/crankshaft/lithium-codegen.cc b/src/crankshaft/lithium-codegen.cc

index 5bd1e6a9b872426627bc306eb5bbec9f95b64306..c5b7e9c470e805799faee77cd59534fa1dba4840 100644

--- a/src/crankshaft/lithium-codegen.cc

+++ b/src/crankshaft/lithium-codegen.cc

@@ -154,7 +154,9 @@ void LCodeGenBase::Comment(const char* format, ...) {

void LCodeGenBase::DeoptComment(const Deoptimizer::DeoptInfo& deopt_info) {

- masm()->RecordDeoptReason(deopt_info.deopt_reason, deopt_info.position);

+ SourcePosition position = deopt_info.position;

+ int raw_position = position.IsUnknown() ? 0 : position.raw();

+ masm()->RecordDeoptReason(deopt_info.deopt_reason, raw_position);

}