Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 1581083004: Fix NULL crash in PrintViewManager::PrintPreviewDone. (Closed)

Created:
4 years, 11 months ago by hcarmona
Modified:
4 years, 11 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix NULL crash in PrintViewManager::PrintPreviewDone. BUG=538612 Committed: https://crrev.com/8720794e92dc9c82466a608d2cec1dc8fc8adabb Cr-Commit-Position: refs/heads/master@{#369341}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M chrome/browser/printing/print_preview_dialog_controller.cc View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
hcarmona
PTAL, this is the fix we talked about.
4 years, 11 months ago (2016-01-14 01:27:21 UTC) #2
Lei Zhang
lgtm
4 years, 11 months ago (2016-01-14 01:28:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1581083004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1581083004/1
4 years, 11 months ago (2016-01-14 01:31:11 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_TIMED_OUT, no build URL) android_chromium_gn_compile_dbg on ...
4 years, 11 months ago (2016-01-14 03:31:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1581083004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1581083004/1
4 years, 11 months ago (2016-01-14 03:46:35 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/110986)
4 years, 11 months ago (2016-01-14 04:21:03 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1581083004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1581083004/1
4 years, 11 months ago (2016-01-14 05:06:38 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-14 05:43:54 UTC) #14
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 05:45:21 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8720794e92dc9c82466a608d2cec1dc8fc8adabb
Cr-Commit-Position: refs/heads/master@{#369341}

Powered by Google App Engine
This is Rietveld 408576698