[es7] implement Object.values() / Object.entries() proposal

[es7] implement Object.values() / Object.entries() proposal

BUG=v8:4663
LOG=N
TBR=hpayer@chromium.org
R=ljharb@gmail.com, rossberg@chromium.org, adamk@chromium.org

Committed: https://crrev.com/677be73e767f93741204f07061f0216485086f99
Cr-Commit-Position: refs/heads/master@{#33450}

[caitp (gmail), 2016-01-13 04:45:16]

low priority as noted on the bug#, but maybe it will give someone something to
use to criticize or improve on the proposal. There's no hurry to land this one

[rossberg, 2016-01-14 13:18:43]

LGTM with nits

https://codereview.chromium.org/1581033002/diff/1/src/flag-definitions.h
File src/flag-definitions.h (right):

https://codereview.chromium.org/1581033002/diff/1/src/flag-definitions.h#newc...
src/flag-definitions.h:210: V(harmony_object_values, "harmony Object.values")
Nit: ...and entries. Perhaps name the flag harmony_object_iterators?

https://codereview.chromium.org/1581033002/diff/1/test/mjsunit/harmony/object...
File test/mjsunit/harmony/object-entries.js (right):

https://codereview.chromium.org/1581033002/diff/1/test/mjsunit/harmony/object...
test/mjsunit/harmony/object-entries.js:15: var O = {
Maybe add a computed property name.

[caitp (gmail), 2016-01-14 14:13:25]

https://codereview.chromium.org/1581033002/diff/1/src/flag-definitions.h
File src/flag-definitions.h (right):

https://codereview.chromium.org/1581033002/diff/1/src/flag-definitions.h#newc...
src/flag-definitions.h:210: V(harmony_object_values, "harmony Object.values")
On 2016/01/14 13:18:43, rossberg wrote:
> Nit: ...and entries. Perhaps name the flag harmony_object_iterators?

Flag description now includes Object.entries, and flag is now
--harmony-object-values-entries

https://codereview.chromium.org/1581033002/diff/1/test/mjsunit/harmony/object...
File test/mjsunit/harmony/object-entries.js (right):

https://codereview.chromium.org/1581033002/diff/1/test/mjsunit/harmony/object...
test/mjsunit/harmony/object-entries.js:15: var O = {
On 2016/01/14 13:18:43, rossberg wrote:
> Maybe add a computed property name.

Done.

[caitp (gmail), 2016-01-14 15:47:48]

Needs an LGTM for src/heap as well. +ulan?

[caitp (gmail), 2016-01-14 15:47:59]

Description was changed from

==========
[es7] implement Object.values() / Object.entries() proposal

BUG=v8:4663
LOG=N
R=ljharb@gmail.com, rossberg@chromium.org, adamk@chromium.org
==========

to

==========
[es7] implement Object.values() / Object.entries() proposal

BUG=v8:4663
LOG=N
R=ljharb@gmail.com, rossberg@chromium.org, adamk@chromium.org
==========

[caitp (gmail), 2016-01-14 15:47:59]

caitpotter88@gmail.com changed reviewers:
+ ulan@chromium.org

[Dan Ehrenberg, 2016-01-22 01:56:00]

Description was changed from

==========
[es7] implement Object.values() / Object.entries() proposal

BUG=v8:4663
LOG=N
R=ljharb@gmail.com, rossberg@chromium.org, adamk@chromium.org
==========

to

==========
[es7] implement Object.values() / Object.entries() proposal

BUG=v8:4663
LOG=N
TBR=hpayer@chromium.org
R=ljharb@gmail.com, rossberg@chromium.org, adamk@chromium.org
==========

[Dan Ehrenberg, 2016-01-22 01:56:30]

littledan@chromium.org changed reviewers:
+ littledan@chromium.org

[Dan Ehrenberg, 2016-01-22 01:56:30]

The CQ bit was checked by littledan@chromium.org

[Dan Ehrenberg, 2016-01-22 01:56:30]

lgtm

This change looks good to me. For the heap, I listed hpayer as TBR--this is a
really trivial change to the heap, and we've done this on other similar changes
in the past.

[Dan Ehrenberg, 2016-01-22 01:56:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
rossberg@chromium.org
Link to the patchset: https://codereview.chromium.org/1581033002/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2016-01-22 01:56:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1581033002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1581033002/60001

[commit-bot: I haz the power, 2016-01-22 01:58:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-22 01:58:20]

Try jobs failed on following builders:
  v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux_arm_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/12702)
  v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/build...)

[caitp (gmail), 2016-01-22 02:28:44]

On 2016/01/22 01:58:20, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
>   v8_linux_arm_rel on tryserver.v8 (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/12702)
>   v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/build...)

I'll rebase this in a few minutes

[caitp (gmail), 2016-01-22 02:34:27]

The CQ bit was checked by caitpotter88@gmail.com

[caitp (gmail), 2016-01-22 02:34:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
rossberg@chromium.org, littledan@chromium.org
Link to the patchset: https://codereview.chromium.org/1581033002/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2016-01-22 02:34:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1581033002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1581033002/80001

[commit-bot: I haz the power, 2016-01-22 02:35:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-22 02:35:53]

Try jobs failed on following builders:
  v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/...)
  v8_linux64_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/361)
  v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/1...)

[caitp (gmail), 2016-01-22 02:36:21]

The CQ bit was unchecked by caitpotter88@gmail.com

[caitp (gmail), 2016-01-22 02:45:38]

The CQ bit was checked by caitpotter88@gmail.com

[caitp (gmail), 2016-01-22 02:45:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
rossberg@chromium.org, littledan@chromium.org
Link to the patchset: https://codereview.chromium.org/1581033002/#ps100001
(title: "Execution::ToObject() -> Object::ToObject(), test fixups")

[commit-bot: I haz the power, 2016-01-22 02:45:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1581033002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1581033002/100001

[commit-bot: I haz the power, 2016-01-22 03:12:37]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-01-22 03:13:07]

Description was changed from

==========
[es7] implement Object.values() / Object.entries() proposal

BUG=v8:4663
LOG=N
TBR=hpayer@chromium.org
R=ljharb@gmail.com, rossberg@chromium.org, adamk@chromium.org
==========

to

==========
[es7] implement Object.values() / Object.entries() proposal

BUG=v8:4663
LOG=N
TBR=hpayer@chromium.org
R=ljharb@gmail.com, rossberg@chromium.org, adamk@chromium.org

Committed: https://crrev.com/677be73e767f93741204f07061f0216485086f99
Cr-Commit-Position: refs/heads/master@{#33450}
==========

[commit-bot: I haz the power, 2016-01-22 03:13:08]

Patchset 6 (id:??) landed as
https://crrev.com/677be73e767f93741204f07061f0216485086f99
Cr-Commit-Position: refs/heads/master@{#33450}