Issue 15810004: Cleanup: Rename LocalFileSystemTestOriginHelper (aka test_helper_) to SandboxFileSystemTestHelper

Issue 15810004: Cleanup: Rename LocalFileSystemTestOriginHelper (aka test_helper_) to SandboxFileSystemTestHelper (Closed)

Created:
7 years, 7 months ago by kinuko

Modified:
7 years, 7 months ago

Reviewers:
kinuko, Avi (use Gerrit), nhiroki, tzik

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, kinuko+watch, jam, tzik+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Cleanup: Rename LocalFileSystemTestOriginHelper (aka test_helper_) to SandboxFileSystemTestHelper Now LocalFileSystemTestOriginHelper is used only for Sandbox FileSystems, I'd like to rename this to more specific, clear name (as the previous name was too vague and unclear). BUG=241701, 240658 TEST=existing tests TBR=avi@chromium.org, nhiroki@chromium.org, tzik@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202037

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+130 lines, -408 lines)			Patch
M	content/content_tests.gypi	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	webkit/browser/fileapi/obfuscated_file_util_unittest.cc	View	14 chunks	+52 lines, -53 lines	0 comments	Download
M	webkit/browser/fileapi/sandbox_mount_point_provider.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/fileapi/local_file_system_operation_unittest.cc	View	10 chunks	+26 lines, -20 lines	0 comments	Download
D	webkit/fileapi/local_file_system_test_helper.h	View	1 chunk	+0 lines, -100 lines	0 comments	Download
D	webkit/fileapi/local_file_system_test_helper.cc	View	1 chunk	+0 lines, -168 lines	0 comments	Download
A +	webkit/fileapi/sandbox_file_system_test_helper.h	View	4 chunks	+10 lines, -10 lines	0 comments	Download
A +	webkit/fileapi/sandbox_file_system_test_helper.cc	View	6 chunks	+36 lines, -51 lines	0 comments	Download
M	webkit/fileapi/syncable/syncable_file_system_unittest.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 7 (0 generated)

kinuko

PTL... I've wanted to rename/cleanup this class for some time now.

7 years, 7 months ago (2013-05-23 06:19:44 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/15810004/1

7 years, 7 months ago (2013-05-24 05:20:42 UTC) #5

kinuko

7 years, 7 months ago (2013-05-24 09:45:36 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 manually as r202037 (presubmit successful).