Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3258)

Unified Diff: chrome/browser/resources/apps_debugger/js/items_list.js

Issue 15810003: App Developer Tools: Implemented separate tabs for unpacked apps and extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@242747-appdevtools-ux
Patch Set: Feedback from grv. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/apps_debugger/js/items_list.js
diff --git a/chrome/browser/resources/apps_debugger/js/items_list.js b/chrome/browser/resources/apps_debugger/js/items_list.js
index 07ee7b7fd92738dbd01a351c37910171e92db8f1..0cb0633ab27c36151a5e9dcdcb8862accdd6c1bd 100644
--- a/chrome/browser/resources/apps_debugger/js/items_list.js
+++ b/chrome/browser/resources/apps_debugger/js/items_list.js
@@ -5,14 +5,17 @@
cr.define('apps_dev_tool', function() {
'use strict';
- // The list of all apps & extensions.
+ // The list of all packed/unpacked apps and extensions.
var completeList = [];
- // The list of all apps.
- var appList = [];
+ // The list of all packed apps.
+ var packedAppList = [];
- // The list of all extensions.
- var extensionList = [];
+ // The list of all packed extensions.
+ var packedExtensionList = [];
+
+ // The list of all unpacked apps or extensions.
+ var unpackedList = [];
/** const*/ var AppsDevTool = apps_dev_tool.AppsDevTool;
@@ -52,10 +55,13 @@ cr.define('apps_dev_tool', function() {
* Refreshes the app.
*/
function reloadAppDisplay() {
- var extensions = new ItemsList($('extension-settings-list'), extensionList);
- var apps = new ItemsList($('app-settings-list'), appList);
+ var extensions = new ItemsList($('packed-extension-list'),
+ packedExtensionList);
Dan Beam 2013/05/23 19:57:30 nit: var extensions = new ItemsList($('packed-exte
dvh 2013/05/23 20:26:28 Done.
+ var apps = new ItemsList($('packed-app-list'), packedAppList);
+ var unpacked = new ItemsList($('unpacked-list'), unpackedList);
extensions.showItemNodes();
apps.showItemNodes();
+ unpacked.showItemNodes();
}
/**
@@ -63,17 +69,20 @@ cr.define('apps_dev_tool', function() {
* @param {string} filter Curent string in the search box.
*/
function rebuildAppList(filter) {
- appList = [];
- extensionList = [];
+ packedAppList = [];
+ packedExtensionList = [];
+ unpackedList = [];
for (var i = 0; i < completeList.length; i++) {
var item = completeList[i];
if (filter && item.name.toLowerCase().search(filter.toLowerCase()) < 0)
continue;
- if (item.isApp)
- appList.push(item);
+ if (item.is_unpacked)
+ unpackedList.push(item);
+ else if (item.isApp)
+ packedAppList.push(item);
else
- extensionList.push(item);
+ packedExtensionList.push(item);
}
}

Powered by Google App Engine
This is Rietveld 408576698