Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2832)

Unified Diff: chrome/browser/resources/apps_debugger/js/items_list.js

Issue 15810003: App Developer Tools: Implemented separate tabs for unpacked apps and extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@242747-appdevtools-ux
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/apps_debugger/js/items_list.js
diff --git a/chrome/browser/resources/apps_debugger/js/items_list.js b/chrome/browser/resources/apps_debugger/js/items_list.js
index 07ee7b7fd92738dbd01a351c37910171e92db8f1..7cfbdf1681affed8a9e5b330be2bc946403eea21 100644
--- a/chrome/browser/resources/apps_debugger/js/items_list.js
+++ b/chrome/browser/resources/apps_debugger/js/items_list.js
@@ -5,7 +5,7 @@
cr.define('apps_dev_tool', function() {
'use strict';
- // The list of all apps & extensions.
+ // The list of all apps & extensions & unpacked.
Gaurav 2013/05/23 17:13:24 May be "The list of all packed/unpacked apps and
dvh 2013/05/23 18:07:23 Done.
var completeList = [];
// The list of all apps.
Gaurav 2013/05/23 17:13:24 This doesn't include unpacked rgt ? May be: inst
dvh 2013/05/23 18:07:23 I use packedExtensionList, same apply to packedApp
@@ -14,6 +14,9 @@ cr.define('apps_dev_tool', function() {
// The list of all extensions.
var extensionList = [];
Gaurav 2013/05/23 17:13:24 as above
dvh 2013/05/23 18:07:23 Done.
+ // The list of all unpacked apps or extensions.
+ var unpackedList = [];
+
/** const*/ var AppsDevTool = apps_dev_tool.AppsDevTool;
/**
@@ -54,8 +57,10 @@ cr.define('apps_dev_tool', function() {
function reloadAppDisplay() {
var extensions = new ItemsList($('extension-settings-list'), extensionList);
dvh 2013/05/23 18:07:23 I renamed the element id too.
var apps = new ItemsList($('app-settings-list'), appList);
+ var unpacked = new ItemsList($('unpacked-settings-list'), unpackedList);
extensions.showItemNodes();
apps.showItemNodes();
+ unpacked.showItemNodes();
}
/**
@@ -65,12 +70,15 @@ cr.define('apps_dev_tool', function() {
function rebuildAppList(filter) {
appList = [];
extensionList = [];
+ unpackedList = [];
for (var i = 0; i < completeList.length; i++) {
var item = completeList[i];
if (filter && item.name.toLowerCase().search(filter.toLowerCase()) < 0)
continue;
- if (item.isApp)
+ if (item.is_unpacked)
+ unpackedList.push(item);
+ else if (item.isApp)
appList.push(item);
else
extensionList.push(item);
« no previous file with comments | « chrome/browser/resources/apps_debugger/css/items.css ('k') | chrome/browser/resources/apps_debugger/main.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698