App Developer Tools: Implemented separate tabs for unpacked apps and extensions.

Implemented separate tabs for unpacked apps and extensions in App Developer Tools.

BUG=237277
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202840

[dvh, 2013-05-23 05:16:52]

PTAL.

[Gaurav, 2013-05-23 17:13:24]

https://codereview.chromium.org/15810003/diff/1/chrome/browser/resources/apps...
File chrome/browser/resources/apps_debugger/js/items_list.js (right):

https://codereview.chromium.org/15810003/diff/1/chrome/browser/resources/apps...
chrome/browser/resources/apps_debugger/js/items_list.js:8: // The list of all
apps & extensions & unpacked.
May be

"The list of all packed/unpacked apps and extensions."

or

"The list of all apps and extensions.

https://codereview.chromium.org/15810003/diff/1/chrome/browser/resources/apps...
chrome/browser/resources/apps_debugger/js/items_list.js:11: // The list of all
apps.
This doesn't include unpacked rgt ?

May be:

installedExtensions

https://codereview.chromium.org/15810003/diff/1/chrome/browser/resources/apps...
chrome/browser/resources/apps_debugger/js/items_list.js:15: var extensionList =
[];
as above

[dvh, 2013-05-23 18:07:23]

PTAL.

https://codereview.chromium.org/15810003/diff/1/chrome/browser/resources/apps...
File chrome/browser/resources/apps_debugger/js/items_list.js (left):

https://codereview.chromium.org/15810003/diff/1/chrome/browser/resources/apps...
chrome/browser/resources/apps_debugger/js/items_list.js:55: var extensions = new
ItemsList($('extension-settings-list'), extensionList);
I renamed the element id too.

https://codereview.chromium.org/15810003/diff/1/chrome/browser/resources/apps...
File chrome/browser/resources/apps_debugger/js/items_list.js (right):

https://codereview.chromium.org/15810003/diff/1/chrome/browser/resources/apps...
chrome/browser/resources/apps_debugger/js/items_list.js:8: // The list of all
apps & extensions & unpacked.
On 2013/05/23 17:13:24, Gaurav wrote:
> May be
> 
> "The list of all packed/unpacked apps and extensions."
> 
> or
> 
> "The list of all apps and extensions.

Done.

https://codereview.chromium.org/15810003/diff/1/chrome/browser/resources/apps...
chrome/browser/resources/apps_debugger/js/items_list.js:11: // The list of all
apps.
On 2013/05/23 17:13:24, Gaurav wrote:
> This doesn't include unpacked rgt ?
> 
> May be:
> 
> installedExtensions

I use packedExtensionList, same apply to packedAppList.

https://codereview.chromium.org/15810003/diff/1/chrome/browser/resources/apps...
chrome/browser/resources/apps_debugger/js/items_list.js:15: var extensionList =
[];
On 2013/05/23 17:13:24, Gaurav wrote:
> as above

Done.

[Dan Beam, 2013-05-23 19:57:29]

c/b/resources lgtm

https://codereview.chromium.org/15810003/diff/5001/chrome/browser/resources/a...
File chrome/browser/resources/apps_debugger/js/items_list.js (right):

https://codereview.chromium.org/15810003/diff/5001/chrome/browser/resources/a...
chrome/browser/resources/apps_debugger/js/items_list.js:59:
packedExtensionList);
nit: var extensions = new ItemsList($('packed-extension-list'),
                                    packedExtensionList);

https://codereview.chromium.org/15810003/diff/5001/chrome/browser/resources/a...
File chrome/browser/resources/apps_debugger/main.html (right):

https://codereview.chromium.org/15810003/diff/5001/chrome/browser/resources/a...
chrome/browser/resources/apps_debugger/main.html:56: <div id="unpacked-list"
class="empty-extension-list">
nit: <div id="unpacked-list" class="empty-extension-list"></div>

[dvh, 2013-05-23 20:26:28]

I forgot to mention why I included the reviewers:

cpu:
chrome/app/generated_resources.grd

asargent:
chrome/browser/extensions/api/developer_private/developer_private_api.cc

https://codereview.chromium.org/15810003/diff/5001/chrome/browser/resources/a...
File chrome/browser/resources/apps_debugger/js/items_list.js (right):

https://codereview.chromium.org/15810003/diff/5001/chrome/browser/resources/a...
chrome/browser/resources/apps_debugger/js/items_list.js:59:
packedExtensionList);
On 2013/05/23 19:57:30, Dan Beam wrote:
> nit: var extensions = new ItemsList($('packed-extension-list'),
>                                     packedExtensionList);

Done.

https://codereview.chromium.org/15810003/diff/5001/chrome/browser/resources/a...
File chrome/browser/resources/apps_debugger/main.html (right):

https://codereview.chromium.org/15810003/diff/5001/chrome/browser/resources/a...
chrome/browser/resources/apps_debugger/main.html:56: <div id="unpacked-list"
class="empty-extension-list">
On 2013/05/23 19:57:30, Dan Beam wrote:
> nit: <div id="unpacked-list" class="empty-extension-list"></div>

Done.

[asargent_no_longer_on_chrome, 2013-05-23 21:56:32]

lgtm

[asargent_no_longer_on_chrome, 2013-05-23 21:57:52]

dvh - BTW, if you look at the chrome/app/OWNERS file, there is a per-file rule
that says any reviewer can approve changes to generated_resources.grd, so you
don't actually need cpu@ to review.

[commit-bot: I haz the power, 2013-05-29 03:06:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dvh@chromium.org/15810003/30001

[commit-bot: I haz the power, 2013-05-29 11:37:11]

Change committed as 202840