chrome/common/extensions/api/browser_action.json - Issue 1580983002: Fix the dynamic browser action setIcon path to work with any size icon.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/browser_action.json

Issue 1580983002: Fix the dynamic browser action setIcon path to work with any size icon. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: mac compatible image equality check Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/extensions/icon_with_badge_image_source.cc ('K') | « chrome/browser/ui/views/toolbar/toolbar_action_view.cc ('k') | chrome/test/data/extensions/api_test/browser_action/no_icon/background.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/browser_action.json

diff --git a/chrome/common/extensions/api/browser_action.json b/chrome/common/extensions/api/browser_action.json

index d7ff7438db65c837a8fc27d44dfc6c952cfe23c0..0df3432ae4b6958fa6f7d4b70a74b1335b59320b 100644

--- a/chrome/common/extensions/api/browser_action.json

+++ b/chrome/common/extensions/api/browser_action.json

@@ -91,10 +91,7 @@

{ "$ref": "ImageDataType" },

{

"type": "object",

- "properties": {

- "19": {"$ref": "ImageDataType", "optional": true},

- "38": {"$ref": "ImageDataType", "optional": true}

- }

+ "additionalProperties": { "type": "any" }

}

"optional": true,

@@ -105,10 +102,7 @@

{ "type": "string" },

{

"type": "object",

- "properties": {

- "19": {"type": "string", "optional": true},

- "38": {"type": "string", "optional": true}

- }

+ "additionalProperties": { "type": "any" }

}

"optional": true,