chrome/test/data/extensions/api_test/browser_action/no_icon/background.js - Issue 1580983002: Fix the dynamic browser action setIcon path to work with any size icon.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/browser_action/no_icon/background.js

Issue 1580983002: Fix the dynamic browser action setIcon path to work with any size icon. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix rounding error Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/extensions/icon_with_badge_image_source.cc ('K') | « chrome/common/extensions/api/browser_action.json ('k') | chrome/test/data/extensions/api_test/browser_action/no_icon/icon.png » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/browser_action/no_icon/background.js

diff --git a/chrome/test/data/extensions/api_test/browser_action/no_icon/background.js b/chrome/test/data/extensions/api_test/browser_action/no_icon/background.js

index 7d8c6c9e814d483bef7be99efb1341c809c10560..044efa2d14dc6ac78a8934acd4d926573aa220fa 100644

--- a/chrome/test/data/extensions/api_test/browser_action/no_icon/background.js

+++ b/chrome/test/data/extensions/api_test/browser_action/no_icon/background.js

@@ -3,18 +3,18 @@

// found in the LICENSE file.

var canvas = document.getElementById("canvas").getContext('2d').

- getImageData(0, 0, 19, 19);

+ getImageData(0, 0, 21, 21);

var canvasHD = document.getElementById("canvas").getContext('2d').

- getImageData(0, 0, 38, 38);

+ getImageData(0, 0, 42, 42);

var setIconParamQueue = [

{imageData: canvas},

{path: 'icon.png'},

- {imageData: {'19': canvas, '38': canvasHD}},

- {path: {'19': 'icon.png', '38': 'icon.png'}},

- {imageData: {'19': canvas}},

- {path: {'19': 'icon.png'}},

- {imageData: {'38': canvasHD}},

+ {imageData: {'21': canvas, '42': canvasHD}},

+ {path: {'21': 'icon.png', '42': 'icon.png'}},

+ {imageData: {'21': canvas}},

+ {path: {'21': 'icon.png'}},

+ {imageData: {'42': canvasHD}},

{imageData: {}},

{path: {}},

];