chrome/common/extensions/api/browser_action.json - Issue 1580983002: Fix the dynamic browser action setIcon path to work with any size icon.

Unified Diff: chrome/common/extensions/api/browser_action.json

Issue 1580983002: Fix the dynamic browser action setIcon path to work with any size icon. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: move size validation Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_action.cc ('K') | « chrome/browser/ui/views/toolbar/toolbar_action_view.cc ('k') | chrome/common/extensions/api/declarative_content.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/browser_action.json

diff --git a/chrome/common/extensions/api/browser_action.json b/chrome/common/extensions/api/browser_action.json

index d7ff7438db65c837a8fc27d44dfc6c952cfe23c0..8b7898c68f27a706320f95419b3b29dc410edc98 100644

--- a/chrome/common/extensions/api/browser_action.json

+++ b/chrome/common/extensions/api/browser_action.json

@@ -91,28 +91,22 @@

{ "$ref": "ImageDataType" },

{

"type": "object",

- "properties": {

- "19": {"$ref": "ImageDataType", "optional": true},

- "38": {"$ref": "ImageDataType", "optional": true}

- }

+ "additionalProperties": { "type": "any" }

}

"optional": true,

- "description": "Either an ImageData object or a dictionary {size -> ImageData} representing icon to be set. If the icon is specified as a dictionary, the actual image to be used is chosen depending on screen's pixel density. If the number of image pixels that fit into one screen space unit equals <code>scale</code>, then image with size <code>scale</code> * 19 will be selected. Initially only scales 1 and 2 will be supported. At least one image must be specified. Note that 'details.imageData = foo' is equivalent to 'details.imageData = {'19': foo}'"

+ "description": "Either an ImageData object or a dictionary {size -> ImageData} representing icon to be set. If the icon is specified as a dictionary, the actual image to be used is chosen depending on screen's pixel density. If the number of image pixels that fit into one screen space unit equals <code>scale</code>, then image with size <code>scale</code> * n will be selected, where n is the size of the icon in the UI. At least one image must be specified. Note that 'details.imageData = foo' is equivalent to 'details.imageData = {'16': foo}'"

"path": {

"choices": [

{ "type": "string" },

{

"type": "object",

- "properties": {

- "19": {"type": "string", "optional": true},

- "38": {"type": "string", "optional": true}

- }

+ "additionalProperties": { "type": "any" }

}

"optional": true,

- "description": "Either a relative image path or a dictionary {size -> relative image path} pointing to icon to be set. If the icon is specified as a dictionary, the actual image to be used is chosen depending on screen's pixel density. If the number of image pixels that fit into one screen space unit equals <code>scale</code>, then image with size <code>scale</code> * 19 will be selected. Initially only scales 1 and 2 will be supported. At least one image must be specified. Note that 'details.path = foo' is equivalent to 'details.imageData = {'19': foo}'"

+ "description": "Either a relative image path or a dictionary {size -> relative image path} pointing to icon to be set. If the icon is specified as a dictionary, the actual image to be used is chosen depending on screen's pixel density. If the number of image pixels that fit into one screen space unit equals <code>scale</code>, then image with size <code>scale</code> * n will be selected, where n is the size of the icon in the UI. At least one image must be specified. Note that 'details.path = foo' is equivalent to 'details.path = {'16': foo}'"

"tabId": {

"type": "integer",