Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Side by Side Diff: chrome/common/extensions/api/browser_action.json

Issue 1580983002: Fix the dynamic browser action setIcon path to work with any size icon. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: twiddle constant Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 [ 5 [
6 { 6 {
7 "namespace": "browserAction", 7 "namespace": "browserAction",
8 "description": "Use browser actions to put icons in the main Google Chrome t oolbar, to the right of the address bar. In addition to its <a href='browserActi on#icon'>icon</a>, a browser action can also have a <a href='browserAction#toolt ip'>tooltip</a>, a <a href='browserAction#badge'>badge</a>, and a <a href='brows erAction#popups'>popup</a>.", 8 "description": "Use browser actions to put icons in the main Google Chrome t oolbar, to the right of the address bar. In addition to its <a href='browserActi on#icon'>icon</a>, a browser action can also have a <a href='browserAction#toolt ip'>tooltip</a>, a <a href='browserAction#badge'>badge</a>, and a <a href='brows erAction#popups'>popup</a>.",
9 "types": [ 9 "types": [
10 { 10 {
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 "parameters": [ 84 "parameters": [
85 { 85 {
86 "name": "details", 86 "name": "details",
87 "type": "object", 87 "type": "object",
88 "properties": { 88 "properties": {
89 "imageData": { 89 "imageData": {
90 "choices": [ 90 "choices": [
91 { "$ref": "ImageDataType" }, 91 { "$ref": "ImageDataType" },
92 { 92 {
93 "type": "object", 93 "type": "object",
94 "properties": { 94 "additionalProperties": { "type": "any" }
95 "19": {"$ref": "ImageDataType", "optional": true},
96 "38": {"$ref": "ImageDataType", "optional": true}
97 }
98 } 95 }
99 ], 96 ],
100 "optional": true, 97 "optional": true,
101 "description": "Either an ImageData object or a dictionary {size -> ImageData} representing icon to be set. If the icon is specified as a dictio nary, the actual image to be used is chosen depending on screen's pixel density. If the number of image pixels that fit into one screen space unit equals <code> scale</code>, then image with size <code>scale</code> * 19 will be selected. Ini tially only scales 1 and 2 will be supported. At least one image must be specifi ed. Note that 'details.imageData = foo' is equivalent to 'details.imageData = {' 19': foo}'" 98 "description": "Either an ImageData object or a dictionary {size -> ImageData} representing icon to be set. If the icon is specified as a dictio nary, the actual image to be used is chosen depending on screen's pixel density. If the number of image pixels that fit into one screen space unit equals <code> scale</code>, then image with size <code>scale</code> * n will be selected, wher e n is the size of the icon in the UI. At least one image must be specified. Not e that 'details.imageData = foo' is equivalent to 'details.imageData = {'16': fo o}'"
102 }, 99 },
103 "path": { 100 "path": {
104 "choices": [ 101 "choices": [
105 { "type": "string" }, 102 { "type": "string" },
106 { 103 {
107 "type": "object", 104 "type": "object",
108 "properties": { 105 "additionalProperties": { "type": "any" }
109 "19": {"type": "string", "optional": true},
110 "38": {"type": "string", "optional": true}
111 }
112 } 106 }
113 ], 107 ],
114 "optional": true, 108 "optional": true,
115 "description": "Either a relative image path or a dictionary {si ze -> relative image path} pointing to icon to be set. If the icon is specified as a dictionary, the actual image to be used is chosen depending on screen's pix el density. If the number of image pixels that fit into one screen space unit eq uals <code>scale</code>, then image with size <code>scale</code> * 19 will be se lected. Initially only scales 1 and 2 will be supported. At least one image must be specified. Note that 'details.path = foo' is equivalent to 'details.imageDat a = {'19': foo}'" 109 "description": "Either a relative image path or a dictionary {si ze -> relative image path} pointing to icon to be set. If the icon is specified as a dictionary, the actual image to be used is chosen depending on screen's pix el density. If the number of image pixels that fit into one screen space unit eq uals <code>scale</code>, then image with size <code>scale</code> * n will be sel ected, where n is the size of the icon in the UI. At least one image must be spe cified. Note that 'details.path = foo' is equivalent to 'details.path = {'16': f oo}'"
116 }, 110 },
117 "tabId": { 111 "tabId": {
118 "type": "integer", 112 "type": "integer",
119 "optional": true, 113 "optional": true,
120 "description": "Limits the change to when a particular tab is se lected. Automatically resets when the tab is closed." 114 "description": "Limits the change to when a particular tab is se lected. Automatically resets when the tab is closed."
121 } 115 }
122 } 116 }
123 }, 117 },
124 { 118 {
125 "type": "function", 119 "type": "function",
(...skipping 215 matching lines...) Expand 10 before | Expand all | Expand 10 after
341 "parameters": [ 335 "parameters": [
342 { 336 {
343 "name": "tab", 337 "name": "tab",
344 "$ref": "tabs.Tab" 338 "$ref": "tabs.Tab"
345 } 339 }
346 ] 340 ]
347 } 341 }
348 ] 342 ]
349 } 343 }
350 ] 344 ]
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/toolbar/toolbar_action_view.cc ('k') | chrome/common/extensions/api/declarative_content.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698