Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 158093003: Simplify Node::invalidateNodeListCachesInAncestors()'s code a bit (Closed)

Created:
6 years, 10 months ago by Inactive
Modified:
6 years, 10 months ago
Reviewers:
adamk, abarth-chromium
CC:
blink-reviews, dglazkov+blink, sof, eae+blinkwatch, adamk+blink_chromium.org, Inactive
Visibility:
Public.

Description

Simplify Node::invalidateNodeListCachesInAncestors()'s code a bit Simplify Node::invalidateNodeListCachesInAncestors()'s code a bit by re-using Node::nodeLists() getter instead of duplicating its implementation. R=adamk, abarth Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166786

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M Source/core/dom/Node.cpp View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Inactive
6 years, 10 months ago (2014-02-09 15:33:01 UTC) #1
abarth-chromium
lgtm
6 years, 10 months ago (2014-02-09 16:56:15 UTC) #2
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 10 months ago (2014-02-09 17:14:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/158093003/1
6 years, 10 months ago (2014-02-09 17:14:48 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-09 18:53:44 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_blink_rel&number=18040
6 years, 10 months ago (2014-02-09 18:53:45 UTC) #6
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 10 months ago (2014-02-09 23:58:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/158093003/1
6 years, 10 months ago (2014-02-09 23:59:03 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-10 02:45:59 UTC) #9
Message was sent while issue was closed.
Change committed as 166786

Powered by Google App Engine
This is Rietveld 408576698