Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 1580923002: Revert of Move BUILD.public to public.bzl. (Closed)

Created:
4 years, 11 months ago by iroth
Modified:
4 years, 11 months ago
Reviewers:
dogben, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Move BUILD.public to public.bzl. (patchset #1 id:1 of https://codereview.chromium.org/1577353002/ ) Reason for revert: Corresponding google-private changes not ready. Original issue's description: > Move BUILD.public to public.bzl. > > This allows building with bazel (see http://bazel.io). > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1577353002 > > Committed: https://skia.googlesource.com/skia/+/eeebfff54877b24151570c4f02b2299e3f9ef967 TBR=benjaminwagner@google.com,mtklein@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/330043c073de2ee63faa1caa3cb4170da68a79f2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+505 lines, -506 lines) Patch
A BUILD.public View 1 chunk +505 lines, -0 lines 0 comments Download
D public.bzl View 1 chunk +0 lines, -506 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
iroth
Created Revert of Move BUILD.public to public.bzl.
4 years, 11 months ago (2016-01-12 22:19:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1580923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1580923002/1
4 years, 11 months ago (2016-01-12 22:19:54 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 11 months ago (2016-01-12 22:19:55 UTC) #3
dogben
lgtm
4 years, 11 months ago (2016-01-12 22:22:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1580923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1580923002/1
4 years, 11 months ago (2016-01-12 22:22:17 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/330043c073de2ee63faa1caa3cb4170da68a79f2
4 years, 11 months ago (2016-01-12 22:22:26 UTC) #8
dogben
4 years, 11 months ago (2016-01-13 18:45:09 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1584563004/ by benjaminwagner@google.com.

The reason for reverting is: Internal cl/111468120 is now ready to go..

Powered by Google App Engine
This is Rietveld 408576698