Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(730)

Unified Diff: net/http/http_proxy_client_socket_pool_unittest.cc

Issue 1580903002: Convert ignore_limits from a SocketParam to a socket request argument. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_proxy_client_socket_pool_unittest.cc
diff --git a/net/http/http_proxy_client_socket_pool_unittest.cc b/net/http/http_proxy_client_socket_pool_unittest.cc
index 97d7270fa670dc62afcdd4e7555178c27c10c045..dcf6fbfecb439d5b1a4fcd9556718debc4cb8612 100644
--- a/net/http/http_proxy_client_socket_pool_unittest.cc
+++ b/net/http/http_proxy_client_socket_pool_unittest.cc
@@ -211,7 +211,6 @@ class HttpProxyClientSocketPoolTest
return new TransportSocketParams(
HostPortPair(kHttpProxyHost, 80),
false,
- false,
OnHostResolutionCallback(),
TransportSocketParams::COMBINE_CONNECT_AND_WRITE_DEFAULT);
}
@@ -223,7 +222,6 @@ class HttpProxyClientSocketPoolTest
new TransportSocketParams(
HostPortPair(kHttpsProxyHost, 443),
false,
- false,
OnHostResolutionCallback(),
TransportSocketParams::COMBINE_CONNECT_AND_WRITE_DEFAULT),
NULL,
@@ -347,7 +345,7 @@ TEST_P(HttpProxyClientSocketPoolTest, NoTunnel) {
scoped_ptr<TestProxyDelegate> proxy_delegate(new TestProxyDelegate());
int rv = handle_.Init("a", CreateNoTunnelParams(proxy_delegate.get()), LOW,
- CompletionCallback(), &pool_, BoundNetLog());
+ false, CompletionCallback(), &pool_, BoundNetLog());
EXPECT_EQ(OK, rv);
EXPECT_TRUE(handle_.is_initialized());
ASSERT_TRUE(handle_.socket());
@@ -361,9 +359,8 @@ TEST_P(HttpProxyClientSocketPoolTest, NoTunnel) {
// (non-SSL) socket request on Init.
TEST_P(HttpProxyClientSocketPoolTest, SetSocketRequestPriorityOnInit) {
Initialize(NULL, 0, NULL, 0, NULL, 0, NULL, 0);
- EXPECT_EQ(OK,
- handle_.Init("a", CreateNoTunnelParams(NULL), HIGHEST,
- CompletionCallback(), &pool_, BoundNetLog()));
+ EXPECT_EQ(OK, handle_.Init("a", CreateNoTunnelParams(NULL), HIGHEST, false,
+ CompletionCallback(), &pool_, BoundNetLog()));
EXPECT_EQ(HIGHEST, GetLastTransportRequestPriority());
}
@@ -404,7 +401,7 @@ TEST_P(HttpProxyClientSocketPoolTest, NeedAuth) {
spdy_reads, arraysize(spdy_reads), spdy_writes,
arraysize(spdy_writes));
- int rv = handle_.Init("a", CreateTunnelParams(NULL), LOW,
+ int rv = handle_.Init("a", CreateTunnelParams(NULL), LOW, false,
callback_.callback(), &pool_, BoundNetLog());
EXPECT_EQ(ERR_IO_PENDING, rv);
EXPECT_FALSE(handle_.is_initialized());
@@ -454,7 +451,7 @@ TEST_P(HttpProxyClientSocketPoolTest, HaveAuth) {
scoped_ptr<TestProxyDelegate> proxy_delegate(new TestProxyDelegate());
int rv = handle_.Init("a", CreateTunnelParams(proxy_delegate.get()), LOW,
- callback_.callback(), &pool_, BoundNetLog());
+ false, callback_.callback(), &pool_, BoundNetLog());
EXPECT_EQ(OK, rv);
EXPECT_TRUE(handle_.is_initialized());
ASSERT_TRUE(handle_.socket());
@@ -507,7 +504,7 @@ TEST_P(HttpProxyClientSocketPoolTest, AsyncHaveAuth) {
scoped_ptr<TestProxyDelegate> proxy_delegate(new TestProxyDelegate());
int rv = handle_.Init("a", CreateTunnelParams(proxy_delegate.get()), LOW,
- callback_.callback(), &pool_, BoundNetLog());
+ false, callback_.callback(), &pool_, BoundNetLog());
EXPECT_EQ(ERR_IO_PENDING, rv);
EXPECT_FALSE(handle_.is_initialized());
EXPECT_FALSE(handle_.socket());
@@ -546,7 +543,7 @@ TEST_P(HttpProxyClientSocketPoolTest,
AddAuthToCache();
EXPECT_EQ(ERR_IO_PENDING,
- handle_.Init("a", CreateTunnelParams(NULL), MEDIUM,
+ handle_.Init("a", CreateTunnelParams(NULL), MEDIUM, false,
callback_.callback(), &pool_, BoundNetLog()));
EXPECT_EQ(MEDIUM, GetLastTransportRequestPriority());
@@ -560,7 +557,7 @@ TEST_P(HttpProxyClientSocketPoolTest, TCPError) {
socket_factory()->AddSocketDataProvider(data_.get());
- int rv = handle_.Init("a", CreateTunnelParams(NULL), LOW,
+ int rv = handle_.Init("a", CreateTunnelParams(NULL), LOW, false,
callback_.callback(), &pool_, BoundNetLog());
EXPECT_EQ(ERR_IO_PENDING, rv);
EXPECT_FALSE(handle_.is_initialized());
@@ -585,7 +582,7 @@ TEST_P(HttpProxyClientSocketPoolTest, SSLError) {
}
socket_factory()->AddSSLSocketDataProvider(ssl_data_.get());
- int rv = handle_.Init("a", CreateTunnelParams(NULL), LOW,
+ int rv = handle_.Init("a", CreateTunnelParams(NULL), LOW, false,
callback_.callback(), &pool_, BoundNetLog());
EXPECT_EQ(ERR_IO_PENDING, rv);
EXPECT_FALSE(handle_.is_initialized());
@@ -610,7 +607,7 @@ TEST_P(HttpProxyClientSocketPoolTest, SslClientAuth) {
}
socket_factory()->AddSSLSocketDataProvider(ssl_data_.get());
- int rv = handle_.Init("a", CreateTunnelParams(NULL), LOW,
+ int rv = handle_.Init("a", CreateTunnelParams(NULL), LOW, false,
callback_.callback(), &pool_, BoundNetLog());
EXPECT_EQ(ERR_IO_PENDING, rv);
EXPECT_FALSE(handle_.is_initialized());
@@ -649,7 +646,7 @@ TEST_P(HttpProxyClientSocketPoolTest, TunnelUnexpectedClose) {
arraysize(spdy_writes));
AddAuthToCache();
- int rv = handle_.Init("a", CreateTunnelParams(NULL), LOW,
+ int rv = handle_.Init("a", CreateTunnelParams(NULL), LOW, false,
callback_.callback(), &pool_, BoundNetLog());
EXPECT_EQ(ERR_IO_PENDING, rv);
EXPECT_FALSE(handle_.is_initialized());
@@ -687,7 +684,7 @@ TEST_P(HttpProxyClientSocketPoolTest, Tunnel1xxResponse) {
Initialize(reads, arraysize(reads), writes, arraysize(writes),
NULL, 0, NULL, 0);
- int rv = handle_.Init("a", CreateTunnelParams(NULL), LOW,
+ int rv = handle_.Init("a", CreateTunnelParams(NULL), LOW, false,
callback_.callback(), &pool_, BoundNetLog());
EXPECT_EQ(ERR_IO_PENDING, rv);
EXPECT_FALSE(handle_.is_initialized());
@@ -727,7 +724,7 @@ TEST_P(HttpProxyClientSocketPoolTest, TunnelSetupError) {
arraysize(spdy_writes));
AddAuthToCache();
- int rv = handle_.Init("a", CreateTunnelParams(NULL), LOW,
+ int rv = handle_.Init("a", CreateTunnelParams(NULL), LOW, false,
callback_.callback(), &pool_, BoundNetLog());
EXPECT_EQ(ERR_IO_PENDING, rv);
EXPECT_FALSE(handle_.is_initialized());
@@ -788,7 +785,7 @@ TEST_P(HttpProxyClientSocketPoolTest, TunnelSetupRedirect) {
arraysize(spdy_writes));
AddAuthToCache();
- int rv = handle_.Init("a", CreateTunnelParams(NULL), LOW,
+ int rv = handle_.Init("a", CreateTunnelParams(NULL), LOW, false,
callback_.callback(), &pool_, BoundNetLog());
EXPECT_EQ(ERR_IO_PENDING, rv);
EXPECT_FALSE(handle_.is_initialized());

Powered by Google App Engine
This is Rietveld 408576698