Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: third_party/WebKit/Source/platform/heap/Handle.h

Issue 1580883002: Oilpan: move AsyncMethodRunner to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/heap/Handle.h
diff --git a/third_party/WebKit/Source/platform/heap/Handle.h b/third_party/WebKit/Source/platform/heap/Handle.h
index 249ce744d2740e1514dbc952152a2c3f1cf0f84c..14b6b9a378da781bb782228be7f95d475395ac45 100644
--- a/third_party/WebKit/Source/platform/heap/Handle.h
+++ b/third_party/WebKit/Source/platform/heap/Handle.h
@@ -1196,6 +1196,18 @@ template<typename T> PassOwnPtrWillBeRawPtr<T> adoptPtrWillBeNoop(T* ptr) { retu
#endif // ENABLE(OILPAN)
+template<typename T, bool = IsGarbageCollectedType<T>::value>
+class PointerFieldStorageTrait {
haraken 2016/01/13 07:41:56 RawPtrOrMemberTrait ?
sof 2016/01/13 09:41:17 Done, little confusion about what it offers with s
+public:
+using Type = RawPtr<T>;
haraken 2016/01/13 07:41:56 4 indentation
sof 2016/01/13 09:41:17 Done.
+};
+
+template<typename T>
+class PointerFieldStorageTrait<T, true> {
+public:
+ using Type = Member<T>;
+};
+
// Abstraction for injecting calls to an object's 'dispose()' method
// on leaving a stack scope, ensuring earlier release of resources
// than waiting until the object is eventually GCed.
@@ -1217,18 +1229,6 @@ public:
void clear() { m_object.clear(); }
private:
- template<typename U, bool = IsGarbageCollectedType<U>::value>
- class PointerFieldStorageTrait {
- public:
- using Type = RawPtr<U>;
- };
-
- template<typename U>
- class PointerFieldStorageTrait<U, true> {
- public:
- using Type = Member<U>;
- };
-
typename PointerFieldStorageTrait<T>::Type m_object;
};

Powered by Google App Engine
This is Rietveld 408576698