Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6877)

Unified Diff: base/BUILD.gn

Issue 1580873003: Enable handle verifier for tests and add some tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: do not copy variable up scope Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/base.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/BUILD.gn
diff --git a/base/BUILD.gn b/base/BUILD.gn
index 60821ee36313f4ba466002833083e35902768655..8cb8929b296201a88867f4f5873264bed67c575b 100644
--- a/base/BUILD.gn
+++ b/base/BUILD.gn
@@ -24,6 +24,12 @@ import("//build/config/ui.gni")
import("//build/nocompile.gni")
import("//testing/test.gni")
+declare_args() {
+ # Whether to disable the handle verifier hooks.
+ # Hookless parts of the handle verifier will still function.
+ win_disable_handle_verifier_hooks = false
+}
+
if (is_android) {
import("//build/config/android/rules.gni")
}
@@ -1113,6 +1119,10 @@ component("base") {
deps += [ "//base/trace_event/etw_manifest:chrome_events_win" ]
+ if (is_win && win_disable_handle_verifier_hooks) {
+ defines += [ "DISABLE_HANDLE_VERIFIER_HOOKS" ]
+ }
+
if (is_component_build) {
# Copy the VS runtime DLLs into the isolate so that they don't have to be
# preinstalled on the target machine. The debug runtimes have a "d" at
@@ -1882,6 +1892,11 @@ test("base_unittests") {
data += [ "$root_out_dir/base_unittests.dSYM/" ]
}
}
+
+ # This disables one of the handle verifier tests.
+ if (is_win && win_disable_handle_verifier_hooks) {
+ defines = [ "DISABLE_HANDLE_VERIFIER_HOOKS" ]
+ }
}
if (enable_nocompile_tests) {
« no previous file with comments | « no previous file | base/base.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698