Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: build/common.gypi

Issue 1580873003: Enable handle verifier for tests and add some tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: disable handle hooks for drmemory Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 40bb44ed5ce810f947856024d47bacd62b68d2d6..f3e0955cbc76fd1ecd794e153b3fe66f68a3d305 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -1286,6 +1286,7 @@
'android_app_version_code%': '<(android_app_version_code)',
'use_webview_internal_framework%': '<(use_webview_internal_framework)',
'enable_webvr%': '<(enable_webvr)',
+ 'win_disable_handle_verifier_hooks%': '<(win_disable_handle_verifier_hooks)',
# Turns on compiler optimizations in V8 in Debug build.
'v8_optimized_debug%': 1,
@@ -1588,6 +1589,10 @@
'libjpeg_ijg_gyp_path': '<(DEPTH)/third_party/libjpeg/libjpeg.gyp',
'libjpeg_turbo_gyp_path': '<(DEPTH)/third_party/libjpeg_turbo/libjpeg.gyp',
+ # Whether to disable handle verifier hooks.
+ # Hookless parts of the handle verifier will still function.
+ 'win_disable_handle_verifier_hooks%': '0',
+
'conditions': [
['buildtype=="Official"', {
# Continue to embed build meta data in Official builds, basically the
@@ -2313,6 +2318,8 @@
# TODO(rnk): Combine with tsan config to share the builder.
# http://crbug.com/108155
['build_for_tool=="drmemory"', {
+ # Disable the hook based handle verifier, as DrMemory does this job.
+ 'win_disable_handle_verifier_hooks': '1',
# These runtime checks force initialization of stack vars which blocks
# DrMemory's uninit detection.
'win_debug_RuntimeChecks': '0',

Powered by Google App Engine
This is Rietveld 408576698