Enable handle verifier for tests and add some tests.

base/win/scoped_handle.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/win/scoped_handle.h"
 
 #include <stddef.h>
 
 #include <unordered_map>
 
@@ skipping 26 matching lines @@
   DWORD thread_id;
 };
 typedef std::unordered_map<HANDLE, Info, HandleHash> HandleMap;
 
 // g_lock protects the handle map and setting g_active_verifier.
 typedef base::internal::LockImpl NativeLock;
 base::LazyInstance<NativeLock>::Leaky g_lock = LAZY_INSTANCE_INITIALIZER;
 
 bool CloseHandleWrapper(HANDLE handle) {
   if (!::CloseHandle(handle))
-    CHECK(false);
+    LOG(FATAL) << "CloseHandle failed.";
   return true;
 }
 
 // Simple automatic locking using a native critical section so it supports
 // recursive locking.
 class AutoNativeLock {
  public:
   explicit AutoNativeLock(NativeLock& lock) : lock_(lock) {
     lock_.Lock();
   }
@@ skipping 101 matching lines @@
   DWORD thread_id = GetCurrentThreadId();
 
   AutoNativeLock lock(*lock_);
 
   Info handle_info = { owner, pc1, pc2, thread_id };
   std::pair<HANDLE, Info> item(handle, handle_info);
   std::pair<HandleMap::iterator, bool> result = map_.insert(item);
   if (!result.second) {
     Info other = result.first->second;
     base::debug::Alias(&other);
-    CHECK(false);
+    LOG(FATAL) << "Attempt to start tracking already tracked handle.";
   }
 }
 
 void ActiveVerifier::StopTracking(HANDLE handle, const void* owner,
                                   const void* pc1, const void* pc2) {
   if (!enabled_)
     return;
 
   AutoNativeLock lock(*lock_);
   HandleMap::iterator i = map_.find(handle);
   if (i == map_.end())
-    CHECK(false);
+    LOG(FATAL) << "Attempting to close an untracked handle.";
 
   Info other = i->second;
   if (other.owner != owner) {
     base::debug::Alias(&other);
-    CHECK(false);
+    LOG(FATAL) << "Attempting to close a handle not owned by opener.";
   }
 
   map_.erase(i);
 }
 
 void ActiveVerifier::Disable() {
   enabled_ = false;
 }
 
 void ActiveVerifier::OnHandleBeingClosed(HANDLE handle) {
   if (!enabled_)
     return;
 
   AutoNativeLock lock(*lock_);
   if (closing_)
     return;
 
   HandleMap::iterator i = map_.find(handle);
   if (i == map_.end())
     return;
 
   Info other = i->second;
   base::debug::Alias(&other);
-  CHECK(false);
+  LOG(FATAL) << "CloseHandle called on tracked handle.";
 }
 
 }  // namespace
 
 void* GetHandleVerifier() {
   return g_active_verifier;
 }
 
 namespace base {
 namespace win {
@@ skipping 18 matching lines @@
 void DisableHandleVerifier() {
   return ActiveVerifier::Get()->Disable();
 }
 
 void OnHandleBeingClosed(HANDLE handle) {
   return ActiveVerifier::Get()->OnHandleBeingClosed(handle);
 }
 
 }  // namespace win
 }  // namespace base