reorg global initialization, separating core from optional

reorg global initialization, separating core from optional

Chrome will be changed to just inherit our files, with no need to have their own copy. see https://codereview.chromium.org/1581533007/

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1580873002

Committed: https://skia.googlesource.com/skia/+/6054d686e6fecc7261eeb328f27e9e16cd1d3b1e

[reed1, 2016-01-12 21:07:19]

Description was changed from

==========
reorg global initialization, separating core from optional

Chrome will be changed to just inherit our files, with no need to have their own
copy.

BUG=skia:
==========

to

==========
reorg global initialization, separating core from optional

Chrome will be changed to just inherit our files, with no need to have their own
copy.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[reed1, 2016-01-13 13:40:09]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-13 13:40:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1580873002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1580873002/20001

[reed1, 2016-01-13 13:42:11]

reed@google.com changed reviewers:
+ fmalita@chromium.org, mtklein@google.com, robertphillips@google.com

[commit-bot: I haz the power, 2016-01-13 13:51:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-13 13:51:54]

Dry run: This issue passed the CQ dry run.

[reed1, 2016-01-13 13:55:57]

Description was changed from

==========
reorg global initialization, separating core from optional

Chrome will be changed to just inherit our files, with no need to have their own
copy.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
reorg global initialization, separating core from optional

Chrome will be changed to just inherit our files, with no need to have their own
copy. see https://codereview.chromium.org/1581533007/

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[f(malita), 2016-01-13 14:10:32]

lgtm

[mtklein, 2016-01-13 14:15:55]

lgtm

https://codereview.chromium.org/1580873002/diff/20001/src/core/SkGlobalInitia...
File src/core/SkGlobalInitialization_core.cpp (right):

https://codereview.chromium.org/1580873002/diff/20001/src/core/SkGlobalInitia...
src/core/SkGlobalInitialization_core.cpp:22: 
Might be nice to explain what belongs here too like you did in _default.cpp.

I imagine it's 
   // Flattenables implemented in src/core should be registered here.  Otherwise
see _default.cpp.
?

[reed1, 2016-01-13 15:00:02]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-13 15:00:11]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1580873002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1580873002/40001

[reed1, 2016-01-13 15:03:18]

https://codereview.chromium.org/1580873002/diff/20001/src/core/SkGlobalInitia...
File src/core/SkGlobalInitialization_core.cpp (right):

https://codereview.chromium.org/1580873002/diff/20001/src/core/SkGlobalInitia...
src/core/SkGlobalInitialization_core.cpp:22: 
On 2016/01/13 14:15:55, mtklein wrote:
> Might be nice to explain what belongs here too like you did in _default.cpp.
> 
> I imagine it's 
>    // Flattenables implemented in src/core should be registered here. 
Otherwise
> see _default.cpp.
> ?

Done.

[commit-bot: I haz the power, 2016-01-13 15:14:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-13 15:14:10]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-01-13 15:15:53]

lgtm

[robertphillips, 2016-01-13 15:17:19]

Do we need to replicate Chrome's dire warning somewhere ?

[mtklein, 2016-01-13 16:38:12]

On 2016/01/13 15:17:19, robertphillips wrote:
> Do we need to replicate Chrome's dire warning somewhere ?

I don't think so.  The to use SK_DISALLOW_CROSSPROCESS_PICTUREIMAGEFILTERS makes
that comment obsolete.  It's safe to have, e.g. SkPictureImageFilter in Chrome's
flattenable registration because SK_DISALLOW_CROSSPROCESS_PICTUREIMAGEFILTERS
guards it elsewhere.  (You'd hope so, as SkPictureImageFilter _is_ there in
_chromium.cpp)

[reed1, 2016-01-13 16:47:06]

The CQ bit was checked by reed@google.com

[reed1, 2016-01-13 16:47:06]

The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com,
fmalita@chromium.org
Link to the patchset: https://codereview.chromium.org/1580873002/#ps40001
(title: "add dox to _core method")

[commit-bot: I haz the power, 2016-01-13 16:47:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1580873002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1580873002/40001

[commit-bot: I haz the power, 2016-01-13 16:47:57]

Description was changed from

==========
reorg global initialization, separating core from optional

Chrome will be changed to just inherit our files, with no need to have their own
copy. see https://codereview.chromium.org/1581533007/

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
reorg global initialization, separating core from optional

Chrome will be changed to just inherit our files, with no need to have their own
copy. see https://codereview.chromium.org/1581533007/

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/6054d686e6fecc7261eeb328f27e9e16cd1d3b1e
==========

[commit-bot: I haz the power, 2016-01-13 16:47:58]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/6054d686e6fecc7261eeb328f27e9e16cd1d3b1e

[robertphillips, 2016-01-13 17:03:16]

We do lose the tidbit about adding new ImageFilters to the fuzzer.