Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: pkg/polymer/lib/src/declaration.dart

Issue 158083002: introduce web_components pkg for consolidated polyfills (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/polymer/lib/src/build/runner.dart ('k') | pkg/polymer/pubspec.yaml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/polymer/lib/src/declaration.dart
diff --git a/pkg/polymer/lib/src/declaration.dart b/pkg/polymer/lib/src/declaration.dart
index d120340471fc2e4e8d0ad4d8db06ea1c0e672a9e..9201767ccb6ce4851db5b0eac330d9cbe88250f3 100644
--- a/pkg/polymer/lib/src/declaration.dart
+++ b/pkg/polymer/lib/src/declaration.dart
@@ -658,12 +658,16 @@ String _cssTextFromSheet(LinkElement sheet) {
var href = sheet.href;
if (href == '') href = sheet.attributes["href"];
+ // TODO(jmesserly): our build is not doing the right thing for
+ // link rel=stylesheet, see http://dartbug.com/16648
if (js.context != null && js.context.hasProperty('HTMLImports')) {
var jsSheet = new js.JsObject.fromBrowserObject(sheet);
var resource = jsSheet['__resource'];
if (resource != null) return resource;
- _sheetLog.fine('failed to get stylesheet text href="$href"');
- return '';
+ // TODO(jmesserly): figure out why HTMLImports is failing to load these.
+ // Falling back to sync XHR is no good.
+ // _sheetLog.fine('failed to get stylesheet text href="$href"');
+ // return '';
}
// TODO(jmesserly): it seems like polymer-js is always polyfilling
// HTMLImports, because their code depends on "__resource" to work.
« no previous file with comments | « pkg/polymer/lib/src/build/runner.dart ('k') | pkg/polymer/pubspec.yaml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698