pkg/polymer/lib/src/build/linter.dart - Issue 158083002: introduce web_components pkg for consolidated polyfills

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/polymer/lib/src/build/linter.dart

Issue 158083002: introduce web_components pkg for consolidated polyfills (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/polymer/lib/src/build/linter.dart

diff --git a/pkg/polymer/lib/src/build/linter.dart b/pkg/polymer/lib/src/build/linter.dart

index 07e0153640100e6eaeec40e72ebeb9cb6843824e..b553ff0a16d5d44a3e594f062c3555555a83535c 100644

--- a/pkg/polymer/lib/src/build/linter.dart

+++ b/pkg/polymer/lib/src/build/linter.dart

@@ -414,7 +414,7 @@ class _LinterVisitor extends TreeVisitor {

span: node.attributeSpans[name]);

}

- if (value.contains('.') || value.contains('(')) {

Jennifer Messerly 2014/02/08 01:13:29 this was issuing a bogus warning for things like:

+ if (value.contains('(')) {

_logger.warning('Invalid event handler body "$value". Declare a method '

'in your custom element "void handlerName(event, detail, target)" '

'and use the form $name="handlerName".',

« pkg/polymer/CHANGELOG.md ('K') | « pkg/polymer/lib/src/boot.dart ('k') | pkg/polymer/lib/src/build/polyfill_injector.dart » ('j') | pkg/polymer/lib/src/build/polyfill_injector.dart » ('J')