introduce web_components pkg for consolidated polyfills

introduce web_components pkg to replace shadow_dom, html_import, custom_element. This new package is 100% compatible with the polyfills used by http://www.polymer-project.org/

Deletes:
  pkg/shadow_dom
  pkg/custom_element (except web_ui stuff)
  pkg/html_import

Adds:
  pkg/web_components, with README.md and build instructions

Changes:
  pkg/html5lib -- deprecate queryAll/query in favor of *Selector
  pkg/polymer -- test fixes & a few small changes to work with new polyfills, mostly in build
  tests/html/custom -- can't load the CE polyfill at runtime, must now be injected statically via an HTML page, similar to the style @blois used for some custom element tests.

R=blois@google.com, sigmund@google.com

Committed: https://code.google.com/p/dart/source/detail?r=32533

[Jennifer Messerly, 2014-02-08 01:13:28]

Note: this change does not fix interop with <polymer-element> yet. That is for
another CL :)

https://codereview.chromium.org/158083002/diff/1/pkg/polymer/CHANGELOG.md
File pkg/polymer/CHANGELOG.md (right):

https://codereview.chromium.org/158083002/diff/1/pkg/polymer/CHANGELOG.md#new...
pkg/polymer/CHANGELOG.md:12: * New feature: `@ObserveProperty('foo bar.baz')
myMethod() {...}` will cause
forgot to document these last change.

https://codereview.chromium.org/158083002/diff/1/pkg/polymer/lib/src/build/li...
File pkg/polymer/lib/src/build/linter.dart (left):

https://codereview.chromium.org/158083002/diff/1/pkg/polymer/lib/src/build/li...
pkg/polymer/lib/src/build/linter.dart:417: if (value.contains('.') ||
value.contains('(')) {
this was issuing a bogus warning for things like:

{{@item.tapAction}}

there's actually a test that uses it.

https://codereview.chromium.org/158083002/diff/1/pkg/polymer/lib/src/build/po...
File pkg/polymer/lib/src/build/polyfill_injector.dart (right):

https://codereview.chromium.org/158083002/diff/1/pkg/polymer/lib/src/build/po...
pkg/polymer/lib/src/build/polyfill_injector.dart:96: var suffix =
options.releaseMode ? '.js' : '.concat.js';
minified mode actually works now.

https://codereview.chromium.org/158083002/diff/1/pkg/polymer/lib/src/declarat...
File pkg/polymer/lib/src/declaration.dart (right):

https://codereview.chromium.org/158083002/diff/1/pkg/polymer/lib/src/declarat...
pkg/polymer/lib/src/declaration.dart:662: // link rel=stylesheet, see
http://dartbug.com/16648
going to follow up on this bug separately, it was already broken

https://codereview.chromium.org/158083002/diff/1/pkg/polymer/test/noscript_te...
File pkg/polymer/test/noscript_test.dart (left):

https://codereview.chromium.org/158083002/diff/1/pkg/polymer/test/noscript_te...
pkg/polymer/test/noscript_test.dart:14: templateBind(querySelector("#a")).model
= "foo";
this test was crazy before--no synchronization. I'm not sure how it every worked
:\

https://codereview.chromium.org/158083002/diff/1/pkg/third_party/html5lib/lib...
File pkg/third_party/html5lib/lib/dom.dart (right):

https://codereview.chromium.org/158083002/diff/1/pkg/third_party/html5lib/lib...
pkg/third_party/html5lib/lib/dom.dart:257: Element querySelector(String
selectors) =>
I used the new names accidentally, so I figured I'd just go ahead and fix
html5lib :)

https://codereview.chromium.org/158083002/diff/1/pkg/web_components/lib/build...
File pkg/web_components/lib/build.log (right):

https://codereview.chromium.org/158083002/diff/1/pkg/web_components/lib/build...
pkg/web_components/lib/build.log:34: CustomElements:
be729c3ecf62684034a7f813cd2bb25571638f86
all of the hash tags captured here :)
this file is produced by adding "audit" to "grunt" ... see README.md

https://codereview.chromium.org/158083002/diff/1/samples/third_party/todomvc/...
File samples/third_party/todomvc/web/app/app.css (right):

https://codereview.chromium.org/158083002/diff/1/samples/third_party/todomvc/...
samples/third_party/todomvc/web/app/app.css:20: font-smoothing: antialiased;
I updated TodoMVC's CSS file

[blois, 2014-02-08 01:37:01]

Changes lgtm

https://codereview.chromium.org/158083002/diff/1/pkg/web_components/lib/polyf...
File pkg/web_components/lib/polyfill.dart (right):

https://codereview.chromium.org/158083002/diff/1/pkg/web_components/lib/polyf...
pkg/web_components/lib/polyfill.dart:52: void customElementsTakeRecords() {
This should only really be used by unittests, would be good to either give it a
very explicit doc comment that it's for TESTS ONLY or move it to a separate
file.

[Siggi Cherem (dart-lang), 2014-02-10 20:49:22]

lgtm

https://codereview.chromium.org/158083002/diff/1/pkg/polymer/CHANGELOG.md
File pkg/polymer/CHANGELOG.md (right):

https://codereview.chromium.org/158083002/diff/1/pkg/polymer/CHANGELOG.md#new...
pkg/polymer/CHANGELOG.md:8: #### Pub version 0.10.0-dev
maybe mention the fix for link-rel-stylesheet that now will load things with
HTTP.get until we fix it propertly?

https://codereview.chromium.org/158083002/diff/1/pkg/polymer/pubspec.yaml
File pkg/polymer/pubspec.yaml (right):

https://codereview.chromium.org/158083002/diff/1/pkg/polymer/pubspec.yaml#new...
pkg/polymer/pubspec.yaml:14: html5lib: ">=0.10.0-dev <0.10.0"
<0.11.0?

https://codereview.chromium.org/158083002/diff/1/pkg/web_components/README.md
File pkg/web_components/README.md (right):

https://codereview.chromium.org/158083002/diff/1/pkg/web_components/README.md...
pkg/web_components/README.md:31: be included **before** other script tags. Be
sure to include dart-shadowdom.js
dart-shadowdom.js => dart_support.js

https://codereview.chromium.org/158083002/diff/1/pkg/web_components/README.md...
pkg/web_components/README.md:68: [a patched version of
CustomElements](https://github.com/dart-lang/CustomElements/tree/blink_tests).
update? (now that the pull request has been merged)

https://codereview.chromium.org/158083002/diff/1/pkg/web_components/lib/dart_...
File pkg/web_components/lib/dart_support.js (right):

https://codereview.chromium.org/158083002/diff/1/pkg/web_components/lib/dart_...
pkg/web_components/lib/dart_support.js:1: // Copyright (c) 2013, the Dart
project authors.  Please see the AUTHORS file
2014 :)

https://codereview.chromium.org/158083002/diff/1/pkg/web_components/pubspec.yaml
File pkg/web_components/pubspec.yaml (right):

https://codereview.chromium.org/158083002/diff/1/pkg/web_components/pubspec.y...
pkg/web_components/pubspec.yaml:2: version: 0.9.0
this doesn't matter, but maybe we want to start at 0.10.0 since all others seem
to be approaching that number :)?

https://codereview.chromium.org/158083002/diff/1/pkg/web_components/pubspec.y...
pkg/web_components/pubspec.yaml:9: elements, by hiding DOM subtrees under shadow
roots.
not sure whether it helps or makes things more confusing, but should we add a
note that this is not the same as web_components < 0.4?

https://codereview.chromium.org/158083002/diff/1/samples/third_party/todomvc/...
File samples/third_party/todomvc/web/app/app.css (right):

https://codereview.chromium.org/158083002/diff/1/samples/third_party/todomvc/...
samples/third_party/todomvc/web/app/app.css:20: font-smoothing: antialiased;
On 2014/02/08 01:13:29, John Messerly wrote:
> I updated TodoMVC's CSS file

why were we commenting these out? were we getting warnings on some browsers?

[Jennifer Messerly, 2014-02-10 22:17:10]

PTAL!

https://codereview.chromium.org/158083002/diff/1/pkg/polymer/CHANGELOG.md
File pkg/polymer/CHANGELOG.md (right):

https://codereview.chromium.org/158083002/diff/1/pkg/polymer/CHANGELOG.md#new...
pkg/polymer/CHANGELOG.md:8: #### Pub version 0.10.0-dev
On 2014/02/10 20:49:23, Siggi Cherem (dart-lang) wrote:
> maybe mention the fix for link-rel-stylesheet that now will load things with
> HTTP.get until we fix it propertly?

my memory on this is already fuzzy :) But I don't think it is actually different
then the previous behavior. The reason a code change was necessary is that
HTMLImports is provided by platform.js, whereas previously we never used it. So
we started going down a code path that was dead code before now. My "fix" sends
us back down the working-but-slow code path.

https://codereview.chromium.org/158083002/diff/1/pkg/polymer/pubspec.yaml
File pkg/polymer/pubspec.yaml (right):

https://codereview.chromium.org/158083002/diff/1/pkg/polymer/pubspec.yaml#new...
pkg/polymer/pubspec.yaml:14: html5lib: ">=0.10.0-dev <0.10.0"
On 2014/02/10 20:49:23, Siggi Cherem (dart-lang) wrote:
> <0.11.0?

eeek! good catch :)

I also noticed we had wrong deps on observe/template_binding ... maybe a merge
issue. fixed

also, html5lib's version was bumped incorrectly. Fixed that too. Eeek.

https://codereview.chromium.org/158083002/diff/1/pkg/web_components/README.md
File pkg/web_components/README.md (right):

https://codereview.chromium.org/158083002/diff/1/pkg/web_components/README.md...
pkg/web_components/README.md:31: be included **before** other script tags. Be
sure to include dart-shadowdom.js
On 2014/02/10 20:49:23, Siggi Cherem (dart-lang) wrote:
> dart-shadowdom.js => dart_support.js

Done.

https://codereview.chromium.org/158083002/diff/1/pkg/web_components/README.md...
pkg/web_components/README.md:68: [a patched version of
CustomElements](https://github.com/dart-lang/CustomElements/tree/blink_tests).
On 2014/02/10 20:49:23, Siggi Cherem (dart-lang) wrote:
> update? (now that the pull request has been merged)

Update the polyfill? In our moment of triumph?! ;)

in all seriousness, I have this guy passing tests in its current state. As soon
as this CL lands I plan to update it. Will be a good test of the process :)

https://codereview.chromium.org/158083002/diff/1/pkg/web_components/lib/dart_...
File pkg/web_components/lib/dart_support.js (right):

https://codereview.chromium.org/158083002/diff/1/pkg/web_components/lib/dart_...
pkg/web_components/lib/dart_support.js:1: // Copyright (c) 2013, the Dart
project authors.  Please see the AUTHORS file
On 2014/02/10 20:49:23, Siggi Cherem (dart-lang) wrote:
> 2014 :)

Done.

https://codereview.chromium.org/158083002/diff/1/pkg/web_components/lib/polyf...
File pkg/web_components/lib/polyfill.dart (right):

https://codereview.chromium.org/158083002/diff/1/pkg/web_components/lib/polyf...
pkg/web_components/lib/polyfill.dart:52: void customElementsTakeRecords() {
On 2014/02/08 01:37:02, blois wrote:
> This should only really be used by unittests, would be good to either give it
a
> very explicit doc comment that it's for TESTS ONLY or move it to a separate
> file.

Just checking: it's not possible an application could need this to resolve a
behavior difference between polyfill and non-polyfill? e.g.
https://groups.google.com/d/msg/polymer-dev/Df55skoYYNE/z69H9Up7z28J

I will definitely clarify the doc comment that it should not be necessary in
almost all cases.

https://codereview.chromium.org/158083002/diff/1/pkg/web_components/pubspec.yaml
File pkg/web_components/pubspec.yaml (right):

https://codereview.chromium.org/158083002/diff/1/pkg/web_components/pubspec.y...
pkg/web_components/pubspec.yaml:2: version: 0.9.0
On 2014/02/10 20:49:23, Siggi Cherem (dart-lang) wrote:
> this doesn't matter, but maybe we want to start at 0.10.0 since all others
seem
> to be approaching that number :)?

yeah, I was thinking 0.9 since it will get to 0.10 before long ... will likely
rev faster than the others. Actually given that line of reasoning, how about
0.3?  gives us the most headroom.

as far as staying in sync, personally I doubt that will happen, I think we need
to treat versions independently.

https://codereview.chromium.org/158083002/diff/1/pkg/web_components/pubspec.y...
pkg/web_components/pubspec.yaml:9: elements, by hiding DOM subtrees under shadow
roots.
On 2014/02/10 20:49:23, Siggi Cherem (dart-lang) wrote:
> not sure whether it helps or makes things more confusing, but should we add a
> note that this is not the same as web_components < 0.4?

it actually went to 0.2.8...

But yeah, let's not worry about it :). That was like 1.5 yrs ago, I doubt anyone
even remembers.

Besides, it actually is the same package! web_components was our first attempt
at polyfilling CE and Shadow DOM. It is just much more sophisticated now ;)

https://codereview.chromium.org/158083002/diff/1/samples/third_party/todomvc/...
File samples/third_party/todomvc/web/app/app.css (right):

https://codereview.chromium.org/158083002/diff/1/samples/third_party/todomvc/...
samples/third_party/todomvc/web/app/app.css:20: font-smoothing: antialiased;
On 2014/02/10 20:49:23, Siggi Cherem (dart-lang) wrote:
> On 2014/02/08 01:13:29, John Messerly wrote:
> > I updated TodoMVC's CSS file
> 
> why were we commenting these out? were we getting warnings on some browsers?

ah, probably! Still, that isn't a good reason :)

[Siggi Cherem (dart-lang), 2014-02-10 22:35:35]

lgtm!

https://codereview.chromium.org/158083002/diff/1/pkg/web_components/README.md
File pkg/web_components/README.md (right):

https://codereview.chromium.org/158083002/diff/1/pkg/web_components/README.md...
pkg/web_components/README.md:68: [a patched version of
CustomElements](https://github.com/dart-lang/CustomElements/tree/blink_tests).
On 2014/02/10 22:17:11, John Messerly wrote:
> On 2014/02/10 20:49:23, Siggi Cherem (dart-lang) wrote:
> > update? (now that the pull request has been merged)
> 
> Update the polyfill? In our moment of triumph?! ;)
> 
> in all seriousness, I have this guy passing tests in its current state. As
soon
> as this CL lands I plan to update it. Will be a good test of the process :)

sgtm

[Jennifer Messerly, 2014-02-11 01:15:39]

Committed patchset #4 manually as r32533 (presubmit successful).