[defineProperty] Fix non-throwing access check failure

[defineProperty] Fix non-throwing access check failure

ReportFailedAccessCheck() sometimes doesn't throw an exception (it's up
to the embedder). Pretend that OrdinaryDefineOwnProperty() succeeded in
that case. This is consistent with existing behavior of other methods:
- JSObject::DefineOwnPropertyIgnoreAttributes
- JSObject::SetPropertyWithFailedAccessCheck
- Object::SetPropertyWithAccessor

See also commit f66c3f5c356583e0f8e1bab7e6ff1eed86d2d1aa.

BUG=chromium:574217
LOG=n
R=neis@chromium.org

Committed: https://crrev.com/70b7400138f0bffd8fb676c0b9a97424c9e41008
Cr-Commit-Position: refs/heads/master@{#33262}

[Jakob Kummerow, 2016-01-12 17:47:40]

PTAL.

Unfortunately the repro requires content_shell and is flaky there, so I don't
have a good regression test to check in.

[neis, 2016-01-13 08:54:18]

https://codereview.chromium.org/1580823002/diff/1/src/objects.cc
File src/objects.cc (left):

https://codereview.chromium.org/1580823002/diff/1/src/objects.cc#oldcode15545
src/objects.cc:15545: UNREACHABLE();
Did you check if we can RETURN_FAILURE here too?  I'm a bit uneasy about
potentially falling through here.

[Jakob Kummerow, 2016-01-13 12:59:48]

https://codereview.chromium.org/1580823002/diff/1/src/objects.cc
File src/objects.cc (left):

https://codereview.chromium.org/1580823002/diff/1/src/objects.cc#oldcode15545
src/objects.cc:15545: UNREACHABLE();
On 2016/01/13 08:54:17, neis wrote:
> Did you check if we can RETURN_FAILURE here too?  I'm a bit uneasy about
> potentially falling through here.

Done.

[neis, 2016-01-13 13:00:47]

The CQ bit was checked by neis@chromium.org

[neis, 2016-01-13 13:00:48]

The CQ bit was unchecked by neis@chromium.org

[neis, 2016-01-13 13:01:05]

lgtm

[Jakob Kummerow, 2016-01-13 13:01:12]

The CQ bit was checked by jkummerow@chromium.org

[commit-bot: I haz the power, 2016-01-13 13:01:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1580823002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1580823002/20001

[commit-bot: I haz the power, 2016-01-13 13:29:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-13 13:30:03]

Description was changed from

==========
[defineProperty] Fix non-throwing access check failure

ReportFailedAccessCheck() sometimes doesn't throw an exception (it's up
to the embedder). Pretend that OrdinaryDefineOwnProperty() succeeded in
that case. This is consistent with existing behavior of other methods:
- JSObject::DefineOwnPropertyIgnoreAttributes
- JSObject::SetPropertyWithFailedAccessCheck
- Object::SetPropertyWithAccessor

See also commit f66c3f5c356583e0f8e1bab7e6ff1eed86d2d1aa.

BUG=chromium:574217
LOG=n
R=neis@chromium.org
==========

to

==========
[defineProperty] Fix non-throwing access check failure

ReportFailedAccessCheck() sometimes doesn't throw an exception (it's up
to the embedder). Pretend that OrdinaryDefineOwnProperty() succeeded in
that case. This is consistent with existing behavior of other methods:
- JSObject::DefineOwnPropertyIgnoreAttributes
- JSObject::SetPropertyWithFailedAccessCheck
- Object::SetPropertyWithAccessor

See also commit f66c3f5c356583e0f8e1bab7e6ff1eed86d2d1aa.

BUG=chromium:574217
LOG=n
R=neis@chromium.org

Committed: https://crrev.com/70b7400138f0bffd8fb676c0b9a97424c9e41008
Cr-Commit-Position: refs/heads/master@{#33262}
==========

[commit-bot: I haz the power, 2016-01-13 13:30:04]

Patchset 2 (id:??) landed as
https://crrev.com/70b7400138f0bffd8fb676c0b9a97424c9e41008
Cr-Commit-Position: refs/heads/master@{#33262}