Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: runtime/vm/atomic_win.h

Issue 1580813003: Use atomic operations to increment/decrement memory usage counts as multiple threads could be alloc… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: self-code-review Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/atomic_win.h
diff --git a/runtime/vm/atomic_win.h b/runtime/vm/atomic_win.h
index 8e07cd3d20b2330f60d2cc3a8d9e009af41843b6..4172ec443c4a1d1a190252872f1b83b2f3647941 100644
--- a/runtime/vm/atomic_win.h
+++ b/runtime/vm/atomic_win.h
@@ -28,6 +28,22 @@ inline uintptr_t AtomicOperations::FetchAndIncrement(uintptr_t* p) {
}
+inline intptr_t AtomicOperations::FetchAndIncrementBy(intptr_t* p,
+ intptr_t value) {
+#if defined(HOST_ARCH_X64)
+ return static_cast<intptr_t>(
+ InterlockedAdd64(reinterpret_cast<LONGLONG*>(p),
+ static_cast<LONGLONG>(value))) - value;
+#elif defined(HOST_ARCH_IA32)
+ return static_cast<intptr_t>(
+ InterlockedAdd(reinterpret_cast<LONG*>(p),
+ static_cast<LONGLONG>(value))) - value;
+#else
+#error Unsupported host architecture.
+#endif
+}
+
+
inline uintptr_t AtomicOperations::FetchAndDecrement(uintptr_t* p) {
#if defined(HOST_ARCH_X64)
return static_cast<uintptr_t>(
@@ -41,6 +57,22 @@ inline uintptr_t AtomicOperations::FetchAndDecrement(uintptr_t* p) {
}
+inline intptr_t AtomicOperations::FetchAndDecrementBy(intptr_t* p,
+ intptr_t value) {
+#if defined(HOST_ARCH_X64)
+ return static_cast<intptr_t>(
+ InterlockedAdd64(reinterpret_cast<LONGLONG*>(p),
+ static_cast<LONGLONG>(-value))) + value;
+#elif defined(HOST_ARCH_IA32)
+ return static_cast<intptr_t>(
+ InterlockedAdd(reinterpret_cast<LONG*>(p),
+ static_cast<LONGLONG>(-value))) + value;
+#else
+#error Unsupported host architecture.
+#endif
+}
+
+
#if !defined(USING_SIMULATOR)
inline uword AtomicOperations::CompareAndSwapWord(uword* ptr,
uword old_value,
« no previous file with comments | « runtime/vm/atomic_test.cc ('k') | runtime/vm/pages.cc » ('j') | runtime/vm/pages.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698