Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1580803002: Fixes #410 (Closed)

Created:
4 years, 11 months ago by vsm
Modified:
4 years, 11 months ago
Reviewers:
Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fixes #410 This generates calls to methods on may-be-native types property in generic methods. R=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/abdd1463a494e2941b4aa0c006a3363f92039a69

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M lib/runtime/dart/math.js View 2 chunks +3 lines, -3 lines 0 comments Download
M lib/src/codegen/js_codegen.dart View 1 chunk +5 lines, -1 line 0 comments Download
M test/codegen/expect/collection/src/unmodifiable_wrappers.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/collection/wrappers.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
vsm
4 years, 11 months ago (2016-01-12 17:21:58 UTC) #3
Jennifer Messerly
LGTM!
4 years, 11 months ago (2016-01-12 17:34:56 UTC) #4
vsm
4 years, 11 months ago (2016-01-12 17:47:52 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
abdd1463a494e2941b4aa0c006a3363f92039a69 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698