Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 15808006: bookmarks: Bring Bookmark Bubble closer to the mocks. (Closed)

Created:
7 years, 7 months ago by tfarina
Modified:
7 years, 6 months ago
Reviewers:
msw, sky
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

bookmarks: Bring Bookmark Bubble closer to the mocks. This changes the text and color of "Bookmark Added" to match with what is shown in the mocks. BUG=231694 TEST=go to any page, press Ctrl+D or press the star button in the omnibox. Observe the Bookmkar Bubble, the text should read "Bookmark added!" and should be in black color. R=msw@chromium.org, sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203325

Patch Set 1 #

Total comments: 1

Patch Set 2 : rm margins #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M chrome/app/bookmarks_strings.grdp View 1 chunk +10 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
tfarina
Mike, I didn't address the link->button yet. I'm with very limited access to internet connection ...
7 years, 7 months ago (2013-05-26 15:14:53 UTC) #1
msw
Restore the margins or fix the control layout, the bubble looks odd. I suppose the ...
7 years, 7 months ago (2013-05-27 20:47:31 UTC) #2
tfarina
Restored the margins. Please, take another look.
7 years, 6 months ago (2013-05-29 01:48:31 UTC) #3
msw
Update the CL description and this LGTM.
7 years, 6 months ago (2013-05-29 02:10:27 UTC) #4
tfarina
Done.
7 years, 6 months ago (2013-05-29 02:11:14 UTC) #5
tfarina
Scott, ping?
7 years, 6 months ago (2013-05-29 21:13:47 UTC) #6
sky
LGTM
7 years, 6 months ago (2013-05-29 23:36:18 UTC) #7
tfarina
7 years, 6 months ago (2013-05-31 03:40:44 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 manually as r203325 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698