Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 1580783003: Revert of Use Document, rather than document element, for implicit root. (Closed)

Created:
4 years, 11 months ago by Peter Kasting
Modified:
4 years, 11 months ago
Reviewers:
esprehn, szager1, ojan
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src@intersection-observer
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use Document, rather than document element, for implicit root. (patchset #5 id:80001 of https://codereview.chromium.org/1548523002/ ) Reason for revert: Broke Linux Oilpan build: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Oilpan%20Builder/builds/261/steps/compile/logs/stdio Original issue's description: > Use Document, rather than document element, for implicit root. > > To land after: > > https://codereview.chromium.org/1449623002/ > > BUG=570538 > R=esprehn@chromium.org,ojan@chromium.org > > Committed: https://crrev.com/4275523d593c4932fe5c66c12020545cb08c3b0a > Cr-Commit-Position: refs/heads/master@{#369073} TBR=ojan@chromium.org,esprehn@chromium.org,szager@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=570538 Committed: https://crrev.com/a2847547afcb87147dfa313da365f6ed6ca418d2 Cr-Commit-Position: refs/heads/master@{#369100}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -228 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.h View 3 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 3 chunks +0 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
A third_party/WebKit/Source/core/dom/ElementIntersectionObserverData.h View 1 chunk +49 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/dom/ElementIntersectionObserverData.cpp View 1 chunk +95 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ElementRareData.h View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObservation.h View 3 chunks +2 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObservation.cpp View 6 chunks +8 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObserver.h View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObserver.cpp View 5 chunks +17 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObserverController.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/Source/core/dom/NodeIntersectionObserverData.h View 1 chunk +0 lines, -49 lines 0 comments Download
D third_party/WebKit/Source/core/dom/NodeIntersectionObserverData.cpp View 1 chunk +0 lines, -101 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Peter Kasting
Created Revert of Use Document, rather than document element, for implicit root.
4 years, 11 months ago (2016-01-13 03:33:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1580783003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1580783003/1
4 years, 11 months ago (2016-01-13 03:37:39 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-13 03:48:54 UTC) #3
commit-bot: I haz the power
4 years, 11 months ago (2016-01-13 03:51:04 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a2847547afcb87147dfa313da365f6ed6ca418d2
Cr-Commit-Position: refs/heads/master@{#369100}

Powered by Google App Engine
This is Rietveld 408576698