Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1580783002: Reland of "[Proxies] Ship Proxies + Reflect." (Closed)

Created:
4 years, 11 months ago by neis
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com, Michael Hablich, oth
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of "[Proxies] Ship Proxies + Reflect." Failing chromium layout tests were marked for rebaselining. Addition to original CL (https://codereview.chromium.org/1580693002/): Skip some more ignition tests. BUG=v8:3931, v8:1543 LOG=Y R=hablich@chromium.org CC=verwaest@chromium.org, rossberg@chromium.org,rmcilroy, oth Committed: https://crrev.com/96ec06efb0fa73bb3cc74d95bb3f1ebea83233de Cr-Commit-Position: refs/heads/master@{#33244}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M src/flag-definitions.h View 2 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/cctest.status View 1 chunk +2 lines, -0 lines 1 comment Download
M test/mjsunit/mjsunit.status View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Michael Hablich
lgtm lgtm
4 years, 11 months ago (2016-01-12 16:08:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1580783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1580783002/1
4 years, 11 months ago (2016-01-12 16:08:36 UTC) #3
Michael Hablich
Added a comment and added Ignition folks so they know about the disabled tests. https://codereview.chromium.org/1580783002/diff/1/test/cctest/cctest.status ...
4 years, 11 months ago (2016-01-12 16:11:02 UTC) #5
rmcilroy
lgtm
4 years, 11 months ago (2016-01-12 16:16:41 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-12 17:19:49 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-12 17:19:59 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/96ec06efb0fa73bb3cc74d95bb3f1ebea83233de
Cr-Commit-Position: refs/heads/master@{#33244}

Powered by Google App Engine
This is Rietveld 408576698