GN: Use special toolchain for nacl64.exe, force is_component_build off

GN: Use special toolchain for nacl64.exe, force is_component_build off

The nacl64.exe build within the Windows 32-bit x86 Chrome build is not
compatible with component-style builds.  Build nacl64.exe in a special
variant of the x64 toolchain, wherein is_component_build is always false.

BUG=512869
R=bradnelson@chromium.org, dpranke@chromium.org

Committed: https://crrev.com/8fdf65ae2d38dc0c7bb9ff8f36b4c1f48055844a
Cr-Commit-Position: refs/heads/master@{#372217}

[Roland McGrath, 2016-01-15 22:07:46]

PTAL

[bradnelson, 2016-01-15 22:13:16]

The CQ bit was checked by bradnelson@chromium.org

[bradnelson, 2016-01-15 22:13:16]

lgtm

[commit-bot: I haz the power, 2016-01-15 22:14:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1580723006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1580723006/20001

[commit-bot: I haz the power, 2016-01-15 22:23:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-15 22:23:05]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Dirk Pranke, 2016-01-26 01:42:42]

lgtm

https://codereview.chromium.org/1580723006/diff/20001/build/toolchain/win/BUI...
File build/toolchain/win/BUILD.gn (right):

https://codereview.chromium.org/1580723006/diff/20001/build/toolchain/win/BUI...
build/toolchain/win/BUILD.gn:339: x64_toolchain_data = x64_toolchain_data
I'm not actually convinced that using the win_x64_toolchains() template makes
things shorter or easier to maintain, given that you have to add in so much
cruft to work around crbug.com/395883.

[Roland McGrath, 2016-01-28 23:32:42]

The CQ bit was checked by mcgrathr@chromium.org

[commit-bot: I haz the power, 2016-01-28 23:35:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1580723006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1580723006/20001

[commit-bot: I haz the power, 2016-01-29 00:19:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-29 00:20:47]

Description was changed from

==========
GN: Use special toolchain for nacl64.exe, force is_component_build off

The nacl64.exe build within the Windows 32-bit x86 Chrome build is not
compatible with component-style builds.  Build nacl64.exe in a special
variant of the x64 toolchain, wherein is_component_build is always false.

BUG=512869
R=bradnelson@chromium.org, dpranke@chromium.org
==========

to

==========
GN: Use special toolchain for nacl64.exe, force is_component_build off

The nacl64.exe build within the Windows 32-bit x86 Chrome build is not
compatible with component-style builds.  Build nacl64.exe in a special
variant of the x64 toolchain, wherein is_component_build is always false.

BUG=512869
R=bradnelson@chromium.org, dpranke@chromium.org

Committed: https://crrev.com/8fdf65ae2d38dc0c7bb9ff8f36b4c1f48055844a
Cr-Commit-Position: refs/heads/master@{#372217}
==========

[commit-bot: I haz the power, 2016-01-29 00:20:48]

Patchset 2 (id:??) landed as
https://crrev.com/8fdf65ae2d38dc0c7bb9ff8f36b4c1f48055844a
Cr-Commit-Position: refs/heads/master@{#372217}

[joedow, 2016-01-29 00:48:00]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1643803006/ by joedow@chromium.org.

The reason for reverting is: We are seeing errors on Win x64 fre/chk GN build
bots and this is the most likely cause.  Reverting..